github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 11:42:54 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #4955] [MERGED] Update @actual-app/components/input to be based on react-aria-components Input component #5680

New Issue
Closed
opened 2026-02-28 21:16:38 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:16:38 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/4955
Author: @joel-jeremy
Created: 5/6/2025
Status: ✅ Merged
Merged: 5/22/2025
Merged by: @joel-jeremy

Base: master ← Head: react-aria-Input

📝 Commits (10+)

  • 615f210 Update @actual-app/components/input to use react-aria-components Input component
  • 1aa317d Cleanup
  • 9a1cd46 Dummy commit
  • b8d833d Remove marginRight being magically added by Stack component
  • 5bf6ad6 Update 4955.md
  • 6f83f5d Update selection background color to match current color
  • 4b265ad Update selection background color
  • 0327aa0 Dummy commit
  • afa2ed4 Fix ConfigServer styles
  • 96c3dce Fix lint error

📊 Changes

39 files changed (+375 additions, -339 deletions)

View changed files

📝 packages/component-library/src/Input.tsx (+63 -55)
📝 packages/desktop-client/e2e/transactions.test.ts-snapshots/Transactions-creates-a-transfer-test-transaction-1-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/transactions.test.ts-snapshots/Transactions-creates-a-transfer-test-transaction-3-chromium-linux.png (+0 -0)
📝 packages/desktop-client/src/components/EditablePageHeaderTitle.tsx (+2 -2)
📝 packages/desktop-client/src/components/accounts/Header.tsx (+7 -5)
📝 packages/desktop-client/src/components/accounts/Reconcile.tsx (+37 -33)
📝 packages/desktop-client/src/components/autocomplete/Autocomplete.tsx (+20 -18)
📝 packages/desktop-client/src/components/autocomplete/PayeeAutocomplete.tsx (+1 -1)
📝 packages/desktop-client/src/components/budget/envelope/CoverMenu.tsx (+44 -35)
📝 packages/desktop-client/src/components/budget/envelope/HoldMenu.tsx (+34 -32)
📝 packages/desktop-client/src/components/budget/envelope/TransferMenu.tsx (+43 -41)
📝 packages/desktop-client/src/components/common/Modal.tsx (+4 -6)
📝 packages/desktop-client/src/components/common/Search.tsx (+12 -14)
📝 packages/desktop-client/src/components/filters/FiltersMenu.jsx (+1 -1)
📝 packages/desktop-client/src/components/filters/NameFilter.tsx (+1 -1)
📝 packages/desktop-client/src/components/manager/ConfigServer.tsx (+5 -4)
📝 packages/desktop-client/src/components/manager/subscribe/ConfirmPasswordForm.tsx (+4 -3)
📝 packages/desktop-client/src/components/manager/subscribe/Login.tsx (+1 -1)
📝 packages/desktop-client/src/components/mobile/MobileForms.tsx (+1 -1)
📝 packages/desktop-client/src/components/mobile/transactions/TransactionListWithBalances.tsx (+1 -1)

...and 19 more files

📄 Description

This will allow us to use the this Input component with other react-aria-components goodies

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/4955 **Author:** [@joel-jeremy](https://github.com/joel-jeremy) **Created:** 5/6/2025 **Status:** ✅ Merged **Merged:** 5/22/2025 **Merged by:** [@joel-jeremy](https://github.com/joel-jeremy) **Base:** `master` ← **Head:** `react-aria-Input` --- ### 📝 Commits (10+) - [`615f210`](https://github.com/actualbudget/actual/commit/615f210dbfb3fbb87d248a61736eed07dc031dc6) Update @actual-app/components/input to use react-aria-components Input component - [`1aa317d`](https://github.com/actualbudget/actual/commit/1aa317de3eae92d35c0e1a3203e0032127a4e730) Cleanup - [`9a1cd46`](https://github.com/actualbudget/actual/commit/9a1cd46c21f0b327bde69e59101b3d7eb451a4b5) Dummy commit - [`b8d833d`](https://github.com/actualbudget/actual/commit/b8d833de34dafbf855b8d7b5ac6ab12d23c34e6f) Remove marginRight being magically added by Stack component - [`5bf6ad6`](https://github.com/actualbudget/actual/commit/5bf6ad6f0e76c77e6347591ca13bf02cfa7a50f3) Update 4955.md - [`6f83f5d`](https://github.com/actualbudget/actual/commit/6f83f5d7b655a69ee3e2579ab187a938ff94f001) Update selection background color to match current color - [`4b265ad`](https://github.com/actualbudget/actual/commit/4b265ad4c7361972990668425eefec0f6d220be4) Update selection background color - [`0327aa0`](https://github.com/actualbudget/actual/commit/0327aa028ed5b21a84716012d947bd396beafc9f) Dummy commit - [`afa2ed4`](https://github.com/actualbudget/actual/commit/afa2ed4a78946df81c8ba6ccec1805b9b5c39fe9) Fix ConfigServer styles - [`96c3dce`](https://github.com/actualbudget/actual/commit/96c3dce909cf30464a39f3a1409d1f0b2257abba) Fix lint error ### 📊 Changes **39 files changed** (+375 additions, -339 deletions) <details> <summary>View changed files</summary> 📝 `packages/component-library/src/Input.tsx` (+63 -55) 📝 `packages/desktop-client/e2e/transactions.test.ts-snapshots/Transactions-creates-a-transfer-test-transaction-1-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/transactions.test.ts-snapshots/Transactions-creates-a-transfer-test-transaction-3-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/src/components/EditablePageHeaderTitle.tsx` (+2 -2) 📝 `packages/desktop-client/src/components/accounts/Header.tsx` (+7 -5) 📝 `packages/desktop-client/src/components/accounts/Reconcile.tsx` (+37 -33) 📝 `packages/desktop-client/src/components/autocomplete/Autocomplete.tsx` (+20 -18) 📝 `packages/desktop-client/src/components/autocomplete/PayeeAutocomplete.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/budget/envelope/CoverMenu.tsx` (+44 -35) 📝 `packages/desktop-client/src/components/budget/envelope/HoldMenu.tsx` (+34 -32) 📝 `packages/desktop-client/src/components/budget/envelope/TransferMenu.tsx` (+43 -41) 📝 `packages/desktop-client/src/components/common/Modal.tsx` (+4 -6) 📝 `packages/desktop-client/src/components/common/Search.tsx` (+12 -14) 📝 `packages/desktop-client/src/components/filters/FiltersMenu.jsx` (+1 -1) 📝 `packages/desktop-client/src/components/filters/NameFilter.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/manager/ConfigServer.tsx` (+5 -4) 📝 `packages/desktop-client/src/components/manager/subscribe/ConfirmPasswordForm.tsx` (+4 -3) 📝 `packages/desktop-client/src/components/manager/subscribe/Login.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/mobile/MobileForms.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/mobile/transactions/TransactionListWithBalances.tsx` (+1 -1) _...and 19 more files_ </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes. Try running yarn generate:release-notes *before* pushing your PR for an interactive experience. --> This will allow us to use the this Input component with other react-aria-components goodies --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:16:38 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#5680
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?