github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 07:01:45 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #5798] [CLOSED] Propose patch for github issue 5680 #32052

New Issue
Closed
opened 2026-04-18 08:10:40 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-18 08:10:40 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/5798
Author: @MatissJanis
Created: 9/26/2025
Status: ❌ Closed

Base: master ← Head: cursor/propose-patch-for-github-issue-5680-2a18

📝 Commits (2)

  • 52b295c Checkpoint before follow-up message
  • 14ff32a Update submodule to latest commit

📊 Changes

1 file changed (+1 additions, -0 deletions)

View changed files

➕ actual (+1 -0)

📄 Description

aql: preserve inner in string literals; fix notes tag regex for (#5680)

Why:
This PR fixes an issue where filtering by notes tags containing a dollar sign ($) was broken. Previously, the AQL compiler aggressively unescaped all \$ occurrences in string literals, which incorrectly transformed user-intended regex patterns (e.g., \$end) into $end. This change ensures that \$ is only unescaped if it appears at the beginning of a string literal, preserving inner \$ for literal matching in regex patterns.

What:

  • packages/loot-core/src/server/aql/compiler.ts: Modified string literal unescaping to only target a leading \$.
  • packages/loot-core/src/server/aql/compiler.test.ts: Added a unit test to verify that inner \$ remains correctly escaped in compiled SQL for $regexp operations.

Open in Cursor Open in Web

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/5798 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 9/26/2025 **Status:** ❌ Closed **Base:** `master` ← **Head:** `cursor/propose-patch-for-github-issue-5680-2a18` --- ### 📝 Commits (2) - [`52b295c`](https://github.com/actualbudget/actual/commit/52b295c81c1f59170625279dcfa978890f54df5b) Checkpoint before follow-up message - [`14ff32a`](https://github.com/actualbudget/actual/commit/14ff32a31ca2c48cc75a72c32aaebb365ced3499) Update submodule to latest commit ### 📊 Changes **1 file changed** (+1 additions, -0 deletions) <details> <summary>View changed files</summary> ➕ `actual` (+1 -0) </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes. Try running yarn generate:release-notes *before* pushing your PR for an interactive experience. --> ### aql: preserve inner $ in string literals; fix notes tag regex for $ (#5680) **Why:** This PR fixes an issue where filtering by notes tags containing a dollar sign (`$`) was broken. Previously, the AQL compiler aggressively unescaped *all* `\$` occurrences in string literals, which incorrectly transformed user-intended regex patterns (e.g., `\$end`) into `$end`. This change ensures that `\$` is only unescaped if it appears at the *beginning* of a string literal, preserving inner `\$` for literal matching in regex patterns. **What:** * **`packages/loot-core/src/server/aql/compiler.ts`**: Modified string literal unescaping to only target a leading `\$`. * **`packages/loot-core/src/server/aql/compiler.test.ts`**: Added a unit test to verify that inner `\$` remains correctly escaped in compiled SQL for `$regexp` operations. --- <a href="https://cursor.com/background-agent?bcId=bc-eb16f07e-8f6c-4124-90cb-dd06adbf7760"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/open-in-cursor-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/open-in-cursor-light.svg"><img alt="Open in Cursor" src="https://cursor.com/open-in-cursor.svg"></picture></a>&nbsp;<a href="https://cursor.com/agents?id=bc-eb16f07e-8f6c-4124-90cb-dd06adbf7760"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/open-in-web-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/open-in-web-light.svg"><img alt="Open in Web" src="https://cursor.com/open-in-web.svg"></picture></a> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-18 08:10:40 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#32052
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?