[PR #4847] [MERGED] :electron: Prep for configure server page #5621

Closed
opened 2026-02-28 21:15:31 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/4847
Author: @MikesGlitch
Created: 4/18/2025
Status: Merged
Merged: 4/19/2025
Merged by: @MikesGlitch

Base: masterHead: electron/prep-server-config-ui


📝 Commits (3)

📊 Changes

11 files changed (+106 additions, -40 deletions)

View changed files

📝 packages/desktop-client/src/browser-preload.browser.js (+6 -0)
📝 packages/desktop-electron/index.ts (+19 -5)
📝 packages/desktop-electron/preload.ts (+6 -0)
📝 packages/loot-core/src/platform/server/asyncStorage/__mocks__/index.ts (+13 -8)
📝 packages/loot-core/src/platform/server/asyncStorage/index.d.ts (+2 -1)
📝 packages/loot-core/src/platform/server/asyncStorage/index.electron.ts (+11 -2)
📝 packages/loot-core/src/platform/server/asyncStorage/index.ts (+21 -9)
📝 packages/loot-core/src/server/accounts/app.ts (+2 -4)
📝 packages/loot-core/src/server/preferences/app.ts (+17 -11)
📝 packages/loot-core/typings/window.d.ts (+3 -0)
upcoming-release-notes/4847.md (+6 -0)

📄 Description

Exposing some functions to allow the Electron UI to perform the following actions:

  • Start sync server
  • Stop sync server
  • Get sync server running status

I've also updated the multiGet to be type safe - it was typing everything as string values.

woot


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/4847 **Author:** [@MikesGlitch](https://github.com/MikesGlitch) **Created:** 4/18/2025 **Status:** ✅ Merged **Merged:** 4/19/2025 **Merged by:** [@MikesGlitch](https://github.com/MikesGlitch) **Base:** `master` ← **Head:** `electron/prep-server-config-ui` --- ### 📝 Commits (3) - [`008a607`](https://github.com/actualbudget/actual/commit/008a60761239288b8ba99a02e1c262a5302d9cd0) prep work for configure server page - [`0354ab8`](https://github.com/actualbudget/actual/commit/0354ab82237ccd58c82f9ee3096faf13edd9790b) release notes - [`7c69609`](https://github.com/actualbudget/actual/commit/7c69609037b0992f4043e1eb93b0d3ae9e07168f) better log message ### 📊 Changes **11 files changed** (+106 additions, -40 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/browser-preload.browser.js` (+6 -0) 📝 `packages/desktop-electron/index.ts` (+19 -5) 📝 `packages/desktop-electron/preload.ts` (+6 -0) 📝 `packages/loot-core/src/platform/server/asyncStorage/__mocks__/index.ts` (+13 -8) 📝 `packages/loot-core/src/platform/server/asyncStorage/index.d.ts` (+2 -1) 📝 `packages/loot-core/src/platform/server/asyncStorage/index.electron.ts` (+11 -2) 📝 `packages/loot-core/src/platform/server/asyncStorage/index.ts` (+21 -9) 📝 `packages/loot-core/src/server/accounts/app.ts` (+2 -4) 📝 `packages/loot-core/src/server/preferences/app.ts` (+17 -11) 📝 `packages/loot-core/typings/window.d.ts` (+3 -0) ➕ `upcoming-release-notes/4847.md` (+6 -0) </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes. Try running yarn generate:release-notes *before* pushing your PR for an interactive experience. --> Exposing some functions to allow the Electron UI to perform the following actions: - Start sync server - Stop sync server - Get sync server running status I've also updated the multiGet to be type safe - it was typing everything as string values. ![woot](https://github.com/user-attachments/assets/c6b95509-5252-40de-87b2-894d41fa515b) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:15:31 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#5621