github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 07:01:45 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #5622] Fix range calculator on the MonthPicker component #13091

New Issue
Closed
opened 2026-04-10 21:46:59 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-10 21:46:59 -05:00
Owner
Copy Link

Original Pull Request: https://github.com/actualbudget/actual/pull/5622

State: closed
Merged: Yes

Fixes #5621

There's a weird behavior I can't seem to pinpoint with monthUtils.subMonth and float values, where sometimes the subtraction matches the result's ceiling, and other times it matches its floor, which I suspect is related to date-fns/date-fns#4061. In the meantime, I've simply made the operation always return the result's floor, in order to make the behavior predictable.

Example:
monthUtils.subMonths('2023-01', 4) = 2022-09
monthUtils.subMonths('2023-01', 4.5) = 2022-09

monthUtils.subMonths('2024-11', 4) = 2024-07
monthUtils.subMonths('2024-11', 4.5) = 2024-06

**Original Pull Request:** https://github.com/actualbudget/actual/pull/5622 **State:** closed **Merged:** Yes --- Fixes #5621 There's a weird behavior I can't seem to pinpoint with `monthUtils.subMonth` and float values, where sometimes the subtraction matches the result's ceiling, and other times it matches its floor, which I suspect is related to date-fns/date-fns#4061. In the meantime, I've simply made the operation always return the result's floor, in order to make the behavior predictable. Example: `monthUtils.subMonths('2023-01', 4)` = 2022-09 `monthUtils.subMonths('2023-01', 4.5)` = 2022-09 `monthUtils.subMonths('2024-11', 4)` = 2024-07 `monthUtils.subMonths('2024-11', 4.5)` = 2024-06
GiteaMirror added the pull-request label 2026-04-10 21:46:59 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#13091
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?