github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-10 12:12:39 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #4844] [MERGED] Restore"Reload on all redirects to handle Cloudflare Access auth expiration" #5619

New Issue
Closed
opened 2026-02-28 21:15:30 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:15:30 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/4844
Author: @rgoldfinger
Created: 4/18/2025
Status: ✅ Merged
Merged: 4/19/2025
Merged by: @matt-fidd

Base: master ← Head: revert-4835-revert-4706-rgoldfinger-patch-1

📝 Commits (3)

  • bc109a9 Revert "Revert "Reload on all redirects to handle Cloudflare Access auth expi…"
  • ed405f0 Rename 4706.md to 4844.md
  • a7420e6 Update upcoming-release-notes/4844.md

📊 Changes

2 files changed (+14 additions, -7 deletions)

View changed files

📝 packages/loot-core/src/platform/server/fetch/index.ts (+8 -7)
➕ upcoming-release-notes/4844.md (+6 -0)

📄 Description

Reverts actualbudget/actual#4835 and restores #4706.

This change was reverted because of a reported issue logging in with OpenID. However, this turned out to be unrelated to this change.

While investigating that, I noticed there was a res.redirect call that I had missed in the initial PR. It is safe however, because that endpoint /openid/callback is not called from within our code/ the fetch function in this PR, rather, from the browser as it completes the login redirects. https://github.com/actualbudget/actual/blob/master/packages/sync-server/src/accounts/openid.js#L75

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/4844 **Author:** [@rgoldfinger](https://github.com/rgoldfinger) **Created:** 4/18/2025 **Status:** ✅ Merged **Merged:** 4/19/2025 **Merged by:** [@matt-fidd](https://github.com/matt-fidd) **Base:** `master` ← **Head:** `revert-4835-revert-4706-rgoldfinger-patch-1` --- ### 📝 Commits (3) - [`bc109a9`](https://github.com/actualbudget/actual/commit/bc109a9ff68de072e37c71e2f50c2824f46304c7) Revert "Revert "Reload on all redirects to handle Cloudflare Access auth expi…" - [`ed405f0`](https://github.com/actualbudget/actual/commit/ed405f02aae0dc2cbdcf6150fc124187a61bcca9) Rename 4706.md to 4844.md - [`a7420e6`](https://github.com/actualbudget/actual/commit/a7420e6726eea9f6a8da8f8a4e2ce8e2678c765a) Update upcoming-release-notes/4844.md ### 📊 Changes **2 files changed** (+14 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `packages/loot-core/src/platform/server/fetch/index.ts` (+8 -7) ➕ `upcoming-release-notes/4844.md` (+6 -0) </details> ### 📄 Description Reverts actualbudget/actual#4835 and restores #4706. This change was reverted because of a [reported issue](https://discord.com/channels/937901803608096828/1245792355748155392/1362419512015585443) logging in with OpenID. However, this turned out to be [unrelated to this change](https://github.com/actualbudget/actual/pull/4836). While investigating that, I noticed there was a `res.redirect` call that I had missed in the initial PR. It is safe however, because that endpoint `/openid/callback` is not called from within our code/ the fetch function in this PR, rather, from the browser as it completes the login redirects. https://github.com/actualbudget/actual/blob/master/packages/sync-server/src/accounts/openid.js#L75 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:15:30 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#5619
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?