github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-10 20:23:07 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #4820] [MERGED] Move loot-core/client/notifications code over to desktop-client package #5599

New Issue
Closed
opened 2026-02-28 21:15:06 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:15:06 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/4820
Author: @joel-jeremy
Created: 4/15/2025
Status: ✅ Merged
Merged: 5/14/2025
Merged by: @joel-jeremy

Base: master ← Head: loot-core-client-notifications-to-desktop-client

📝 Commits (3)

  • 857885b Move loot-core/client/modals code over to desktop-client package
  • fa54a37 Fix lint error
  • 44175ac Move loot-core/client/notifications code over to desktop-client package

📊 Changes

37 files changed (+86 additions, -62 deletions)

View changed files

📝 packages/desktop-client/src/accounts/accountsSlice.ts (+1 -1)
📝 packages/desktop-client/src/components/App.tsx (+1 -1)
📝 packages/desktop-client/src/components/FinancesApp.tsx (+1 -1)
📝 packages/desktop-client/src/components/Notifications.tsx (+1 -2)
📝 packages/desktop-client/src/components/ServerContext.tsx (+1 -1)
📝 packages/desktop-client/src/components/accounts/Account.tsx (+1 -1)
📝 packages/desktop-client/src/components/admin/UserAccess/UserAccess.tsx (+1 -1)
📝 packages/desktop-client/src/components/admin/UserAccess/UserAccessRow.tsx (+1 -1)
📝 packages/desktop-client/src/components/admin/UserDirectory/UserDirectory.tsx (+1 -1)
📝 packages/desktop-client/src/components/budget/index.tsx (+1 -1)
📝 packages/desktop-client/src/components/mobile/transactions/TransactionList.tsx (+1 -1)
📝 packages/desktop-client/src/components/modals/CreateAccountModal.tsx (+1 -1)
📝 packages/desktop-client/src/components/modals/EditAccess.tsx (+1 -1)
📝 packages/desktop-client/src/components/modals/EditUser.tsx (+1 -1)
📝 packages/desktop-client/src/components/modals/TransferOwnership.tsx (+1 -1)
📝 packages/desktop-client/src/components/modals/manager/ConfirmChangeDocumentDir.tsx (+1 -2)
📝 packages/desktop-client/src/components/modals/manager/DuplicateFileModal.tsx (+1 -1)
📝 packages/desktop-client/src/components/reports/Overview.tsx (+4 -4)
📝 packages/desktop-client/src/components/reports/reports/Calendar.tsx (+1 -1)
📝 packages/desktop-client/src/components/reports/reports/CashFlow.tsx (+1 -1)

...and 17 more files

📄 Description

The original reason this was designed this way it to share the code with a mobile app. But since we no longer have a mobile app, these codes can now be merged to desktop-client package.

  • accounts folder
  • app folder
  • budgets folder
  • modals folder
  • notifications folder
  • prefs folder
  • queries folder
  • users folder
  • data-hooks folder
  • store folder
  • files under root loot-core/client folder

There will be some suppressed import warning due to loot-core importing some desktop-client files but this is only temporary until we migrate all the files

Changes done:

  1. Move folder from loot-core to desktop-client (vscode does the import updates)
  2. Run yarn lint:fix
  3. Suppress some @actual-app/web imports in loot-core (temporary until all loot-core/client is moved over to desktop-client)
  4. Removed loot-core/server reference to Notification type and replaced with a local type

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/4820 **Author:** [@joel-jeremy](https://github.com/joel-jeremy) **Created:** 4/15/2025 **Status:** ✅ Merged **Merged:** 5/14/2025 **Merged by:** [@joel-jeremy](https://github.com/joel-jeremy) **Base:** `master` ← **Head:** `loot-core-client-notifications-to-desktop-client` --- ### 📝 Commits (3) - [`857885b`](https://github.com/actualbudget/actual/commit/857885b6db1f73e08e8d4584cbfda239dbc154d2) Move loot-core/client/modals code over to desktop-client package - [`fa54a37`](https://github.com/actualbudget/actual/commit/fa54a37f28731e7c011368a85e7089ad075afe73) Fix lint error - [`44175ac`](https://github.com/actualbudget/actual/commit/44175ac3c6296b2cb42c800c529c810a0df27ba8) Move loot-core/client/notifications code over to desktop-client package ### 📊 Changes **37 files changed** (+86 additions, -62 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/accounts/accountsSlice.ts` (+1 -1) 📝 `packages/desktop-client/src/components/App.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/FinancesApp.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/Notifications.tsx` (+1 -2) 📝 `packages/desktop-client/src/components/ServerContext.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/accounts/Account.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/admin/UserAccess/UserAccess.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/admin/UserAccess/UserAccessRow.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/admin/UserDirectory/UserDirectory.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/budget/index.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/mobile/transactions/TransactionList.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/modals/CreateAccountModal.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/modals/EditAccess.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/modals/EditUser.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/modals/TransferOwnership.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/modals/manager/ConfirmChangeDocumentDir.tsx` (+1 -2) 📝 `packages/desktop-client/src/components/modals/manager/DuplicateFileModal.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/reports/Overview.tsx` (+4 -4) 📝 `packages/desktop-client/src/components/reports/reports/Calendar.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/reports/reports/CashFlow.tsx` (+1 -1) _...and 17 more files_ </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes. Try running yarn generate:release-notes *before* pushing your PR for an interactive experience. --> The original reason this was designed this way it to share the code with a mobile app. But since we no longer have a mobile app, these codes can now be merged to `desktop-client` package. - [x] accounts folder - [x] app folder - [x] budgets folder - [x] modals folder - [x] notifications folder - [ ] prefs folder - [ ] queries folder - [ ] users folder - [ ] data-hooks folder - [ ] store folder - [ ] files under root `loot-core/client` folder There will be some suppressed import warning due to loot-core importing some desktop-client files but this is only temporary until we migrate all the files # Changes done: 1. Move folder from loot-core to desktop-client (vscode does the import updates) 2. Run yarn lint:fix 3. Suppress some @actual-app/web imports in loot-core (temporary until all loot-core/client is moved over to desktop-client) 4. **Removed loot-core/server reference to Notification type and replaced with a local type** --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:15:06 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#5599
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?