github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-22 08:52:49 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #4644] [MERGED] ✨ Bank sync avoid reimporting deleted transactions #5505

New Issue
Closed
opened 2026-02-28 21:13:33 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:13:33 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/4644
Author: @alecbakholdin
Created: 3/17/2025
Status: ✅ Merged
Merged: 3/18/2025
Merged by: @youngcw

Base: master ← Head: bank-sync-reimporting-deleted-transactions

📝 Commits (10+)

  • 499b913 matchTransactions imported_id query checks for deleted transactions
  • 257ae6f added release notes
  • 2bfba41 removed stray import
  • 2b86401 Added configuration option to control reimporting deleted transactions
  • 324d332 Updated release notes
  • 975aa14 Unused import
  • e6b0b10 Typo
  • 8687c4d Linting errors
  • 5b54288 Fixed Checkbox id to match what it's for
  • e78e476 Added tooltip for the checkbox

📊 Changes

6 files changed (+179 additions, -2 deletions)

View changed files

📝 packages/desktop-client/src/components/banksync/EditSyncAccount.tsx (+35 -0)
📝 packages/loot-core/src/server/accounts/__snapshots__/sync.test.ts.snap (+82 -0)
📝 packages/loot-core/src/server/accounts/sync.test.ts (+44 -0)
📝 packages/loot-core/src/server/accounts/sync.ts (+11 -2)
📝 packages/loot-core/src/types/prefs.d.ts (+1 -0)
➕ upcoming-release-notes/4644.md (+6 -0)

📄 Description

When you import a transaction using bank-sync, delete it, then re-import it, the transaction gets reimported instead of getting ignored. The reason for this is the v_transactions view filters out deleted transactions. I've updated the matchTransactions method to use the v_transactions_internal "view" (js-defined, looks like?), which includes deleted transactions.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/4644 **Author:** [@alecbakholdin](https://github.com/alecbakholdin) **Created:** 3/17/2025 **Status:** ✅ Merged **Merged:** 3/18/2025 **Merged by:** [@youngcw](https://github.com/youngcw) **Base:** `master` ← **Head:** `bank-sync-reimporting-deleted-transactions` --- ### 📝 Commits (10+) - [`499b913`](https://github.com/actualbudget/actual/commit/499b9132ff258c74529522494417442393a907ce) matchTransactions imported_id query checks for deleted transactions - [`257ae6f`](https://github.com/actualbudget/actual/commit/257ae6f801f2380e00efa5244ef8c828f8349c1f) added release notes - [`2bfba41`](https://github.com/actualbudget/actual/commit/2bfba4153e6736379662b33d35c4150df4129eb4) removed stray import - [`2b86401`](https://github.com/actualbudget/actual/commit/2b8640127e11b7e3a5a00981087f023cb9a9d694) Added configuration option to control reimporting deleted transactions - [`324d332`](https://github.com/actualbudget/actual/commit/324d33230a7befbc1ac1f7cc09c7298ffdb6d079) Updated release notes - [`975aa14`](https://github.com/actualbudget/actual/commit/975aa147c7bd668366656da78d56db5fbb1f2db0) Unused import - [`e6b0b10`](https://github.com/actualbudget/actual/commit/e6b0b10b478ad5823c394099eaee265e7a513442) Typo - [`8687c4d`](https://github.com/actualbudget/actual/commit/8687c4d6931037dc88a201c00613cfdb96543e56) Linting errors - [`5b54288`](https://github.com/actualbudget/actual/commit/5b5428891854b5637d4370f128bf686409054cc8) Fixed Checkbox id to match what it's for - [`e78e476`](https://github.com/actualbudget/actual/commit/e78e4760759375515a0f4f8e54dcb961651b6cfd) Added tooltip for the checkbox ### 📊 Changes **6 files changed** (+179 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/banksync/EditSyncAccount.tsx` (+35 -0) 📝 `packages/loot-core/src/server/accounts/__snapshots__/sync.test.ts.snap` (+82 -0) 📝 `packages/loot-core/src/server/accounts/sync.test.ts` (+44 -0) 📝 `packages/loot-core/src/server/accounts/sync.ts` (+11 -2) 📝 `packages/loot-core/src/types/prefs.d.ts` (+1 -0) ➕ `upcoming-release-notes/4644.md` (+6 -0) </details> ### 📄 Description When you import a transaction using bank-sync, delete it, then re-import it, the transaction gets reimported instead of getting ignored. The reason for this is the v_transactions view filters out deleted transactions. I've updated the matchTransactions method to use the v_transactions_internal "view" (js-defined, looks like?), which includes deleted transactions. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:13:33 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#5505
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?