github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 07:01:45 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #2974] [MERGED] Automatically focus inputs, or the primary button, in modals. #53921

New Issue
Closed
opened 2026-04-30 23:04:46 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-30 23:04:46 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/2974
Author: @psybers
Created: 7/3/2024
Status: ✅ Merged
Merged: 8/15/2024
Merged by: @matt-fidd

Base: master ← Head: autofocus

📝 Commits (10+)

  • d204141 Automatically focus inputs, or the primary button, in modals.
  • 48e73c2 Set focus on more modals.
  • bd94dfc focus mobile transaction edits
  • 4695676 add release note
  • 8854161 fix linter
  • e568671 Merge branch 'master' into autofocus
  • 388094c Merge branch 'master' into autofocus
  • e12f892 fix linter
  • dea466e Merge branch 'master' into autofocus
  • 25e1160 Merge branch 'master' into autofocus

📊 Changes

25 files changed (+128 additions, -81 deletions)

View changed files

📝 packages/desktop-client/src/components/accounts/Account.jsx (+6 -1)
📝 packages/desktop-client/src/components/accounts/AccountSyncCheck.jsx (+1 -0)
📝 packages/desktop-client/src/components/accounts/Reconcile.jsx (+1 -1)
📝 packages/desktop-client/src/components/manager/ImportActual.tsx (+1 -0)
📝 packages/desktop-client/src/components/manager/ImportYNAB4.tsx (+1 -0)
📝 packages/desktop-client/src/components/manager/ImportYNAB5.tsx (+1 -0)
📝 packages/desktop-client/src/components/manager/WelcomeScreen.tsx (+1 -1)
📝 packages/desktop-client/src/components/mobile/transactions/TransactionEdit.jsx (+1 -1)
📝 packages/desktop-client/src/components/modals/CloseAccountModal.tsx (+1 -0)
📝 packages/desktop-client/src/components/modals/ConfirmCategoryDelete.tsx (+2 -1)
📝 packages/desktop-client/src/components/modals/ConfirmTransactionDelete.tsx (+13 -10)
📝 packages/desktop-client/src/components/modals/ConfirmTransactionEdit.tsx (+13 -10)
📝 packages/desktop-client/src/components/modals/ConfirmUnlinkAccount.tsx (+12 -9)
📝 packages/desktop-client/src/components/modals/CreateAccountModal.tsx (+14 -11)
📝 packages/desktop-client/src/components/modals/GoCardlessExternalMsg.tsx (+2 -0)
📝 packages/desktop-client/src/components/modals/GoCardlessInitialise.tsx (+12 -9)
📝 packages/desktop-client/src/components/modals/ImportTransactions.jsx (+1 -0)
📝 packages/desktop-client/src/components/modals/MergeUnusedPayees.jsx (+1 -0)
📝 packages/desktop-client/src/components/modals/SimpleFinInitialise.tsx (+1 -0)
📝 packages/desktop-client/src/components/reports/SaveReportDelete.tsx (+2 -2)

...and 5 more files

📄 Description

Working so that modals will automatically focus the first input, or for confirmation-style modals, autofocus the "primary" button so you can just hit ENTER when it pops up (or ESC).

There are two React Aria button refactoring PRs remaining. It looks like #2915 has no overlap. This PR should be merged after #3163 as it conflicts on one file:

  • packages/desktop-client/src/components/mobile/transactions/TransactionEdit.jsx

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/2974 **Author:** [@psybers](https://github.com/psybers) **Created:** 7/3/2024 **Status:** ✅ Merged **Merged:** 8/15/2024 **Merged by:** [@matt-fidd](https://github.com/matt-fidd) **Base:** `master` ← **Head:** `autofocus` --- ### 📝 Commits (10+) - [`d204141`](https://github.com/actualbudget/actual/commit/d20414188b36ec7b19305cefa7bc860db9f91f62) Automatically focus inputs, or the primary button, in modals. - [`48e73c2`](https://github.com/actualbudget/actual/commit/48e73c2123ce93bd12f9a48491cd18262461a5d3) Set focus on more modals. - [`bd94dfc`](https://github.com/actualbudget/actual/commit/bd94dfc6747fc818495c9a1f69a508ad814390dc) focus mobile transaction edits - [`4695676`](https://github.com/actualbudget/actual/commit/4695676b237dd09224ad42244dcbbc8b54e06425) add release note - [`8854161`](https://github.com/actualbudget/actual/commit/88541611c1ad558ba9a30cbb75a4bd948694b65f) fix linter - [`e568671`](https://github.com/actualbudget/actual/commit/e568671a9e018b4a4ce5ea41f072fe1842a9ad17) Merge branch 'master' into autofocus - [`388094c`](https://github.com/actualbudget/actual/commit/388094c27b235ca3bf17490eceb1f41c2e1f34fd) Merge branch 'master' into autofocus - [`e12f892`](https://github.com/actualbudget/actual/commit/e12f8927a2a06d0ea25354ba3f24b69bdd875d00) fix linter - [`dea466e`](https://github.com/actualbudget/actual/commit/dea466e09e075908c1507c3834994c418faf0f52) Merge branch 'master' into autofocus - [`25e1160`](https://github.com/actualbudget/actual/commit/25e116046bf90b274bc72c9560d3191129829927) Merge branch 'master' into autofocus ### 📊 Changes **25 files changed** (+128 additions, -81 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/accounts/Account.jsx` (+6 -1) 📝 `packages/desktop-client/src/components/accounts/AccountSyncCheck.jsx` (+1 -0) 📝 `packages/desktop-client/src/components/accounts/Reconcile.jsx` (+1 -1) 📝 `packages/desktop-client/src/components/manager/ImportActual.tsx` (+1 -0) 📝 `packages/desktop-client/src/components/manager/ImportYNAB4.tsx` (+1 -0) 📝 `packages/desktop-client/src/components/manager/ImportYNAB5.tsx` (+1 -0) 📝 `packages/desktop-client/src/components/manager/WelcomeScreen.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/mobile/transactions/TransactionEdit.jsx` (+1 -1) 📝 `packages/desktop-client/src/components/modals/CloseAccountModal.tsx` (+1 -0) 📝 `packages/desktop-client/src/components/modals/ConfirmCategoryDelete.tsx` (+2 -1) 📝 `packages/desktop-client/src/components/modals/ConfirmTransactionDelete.tsx` (+13 -10) 📝 `packages/desktop-client/src/components/modals/ConfirmTransactionEdit.tsx` (+13 -10) 📝 `packages/desktop-client/src/components/modals/ConfirmUnlinkAccount.tsx` (+12 -9) 📝 `packages/desktop-client/src/components/modals/CreateAccountModal.tsx` (+14 -11) 📝 `packages/desktop-client/src/components/modals/GoCardlessExternalMsg.tsx` (+2 -0) 📝 `packages/desktop-client/src/components/modals/GoCardlessInitialise.tsx` (+12 -9) 📝 `packages/desktop-client/src/components/modals/ImportTransactions.jsx` (+1 -0) 📝 `packages/desktop-client/src/components/modals/MergeUnusedPayees.jsx` (+1 -0) 📝 `packages/desktop-client/src/components/modals/SimpleFinInitialise.tsx` (+1 -0) 📝 `packages/desktop-client/src/components/reports/SaveReportDelete.tsx` (+2 -2) _...and 5 more files_ </details> ### 📄 Description Working so that modals will automatically focus the first input, or for confirmation-style modals, autofocus the "primary" button so you can just hit ENTER when it pops up (or ESC). There are two React Aria button refactoring PRs remaining. It looks like #2915 has no overlap. This PR should be merged after #3163 as it conflicts on one file: - packages/desktop-client/src/components/mobile/transactions/TransactionEdit.jsx --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-30 23:04:46 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#53921
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?