[PR #475] [MERGED] Add support for filtering the rules list #3163

Closed
opened 2026-02-28 20:37:24 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/475
Author: @j-f1
Created: 1/17/2023
Status: Merged
Merged: 1/31/2023
Merged by: @j-f1

Base: masterHead: search-rules


📝 Commits (7)

  • f2dd48e Move “Rules are always run…” to the top
  • 06bce06 Basic rules list filtering
  • 281ffcc Fix coloring of search field in rules modal
  • 6a8e736 Merge branch 'master' into search-rules
  • b83ba09 Implement full search by payee/category/schedule names
  • 0188834 s → schedule
  • 74436d3 Remove debug log

📊 Changes

1 file changed (+189 additions, -79 deletions)

View changed files

📝 packages/desktop-client/src/components/ManageRules.js (+189 -79)

📄 Description

This PR mostly works (and addresses something that’s been bothering me for a while)! The sticking point is that it can’t properly pull in the names of payees/schedules/categories so they aren’t searchable. Not sure how to fix that without making the app super laggy.

Searches happen essentially based on all of the text displayed in the table.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/475 **Author:** [@j-f1](https://github.com/j-f1) **Created:** 1/17/2023 **Status:** ✅ Merged **Merged:** 1/31/2023 **Merged by:** [@j-f1](https://github.com/j-f1) **Base:** `master` ← **Head:** `search-rules` --- ### 📝 Commits (7) - [`f2dd48e`](https://github.com/actualbudget/actual/commit/f2dd48eb2dc9d8fdc20afa62800ea3f3936c8bf9) Move “Rules are always run…” to the top - [`06bce06`](https://github.com/actualbudget/actual/commit/06bce06d6bbde7ae1d24738075ca98f3e0f23fd8) Basic rules list filtering - [`281ffcc`](https://github.com/actualbudget/actual/commit/281ffccf96ef0c1254ec018b8577842ec8661cd2) Fix coloring of search field in rules modal - [`6a8e736`](https://github.com/actualbudget/actual/commit/6a8e7368666df0c75471a3a7da0ce228d9af81df) Merge branch 'master' into search-rules - [`b83ba09`](https://github.com/actualbudget/actual/commit/b83ba093179e9e05fc1b90718afa537b2f3c8352) Implement full search by payee/category/schedule names - [`0188834`](https://github.com/actualbudget/actual/commit/018883430c53cc850bff87aadfa1fe16b0e286f7) s → schedule - [`74436d3`](https://github.com/actualbudget/actual/commit/74436d314834514ef245d975f6193b6118574938) Remove debug log ### 📊 Changes **1 file changed** (+189 additions, -79 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/ManageRules.js` (+189 -79) </details> ### 📄 Description ~This PR mostly works (and addresses something that’s been bothering me for a while)! The sticking point is that it can’t properly pull in the names of payees/schedules/categories so they aren’t searchable. Not sure how to fix that without making the app super laggy.~ Searches happen essentially based on all of the text displayed in the table. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:37:24 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#3163