github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 07:01:45 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #2651] [MERGED] Improve 'Before split' section in rule splits #53738

New Issue
Closed
opened 2026-04-30 22:39:22 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-30 22:39:22 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/2651
Author: @jfdoming
Created: 4/21/2024
Status: ✅ Merged
Merged: 4/21/2024
Merged by: @youngcw

Base: master ← Head: jfdoming/before-split-improvements

📝 Commits (5)

  • 9fe8cd6 Copy category from parent transaction when splitting
  • 6e5e9fc Rename 'Before split' -> 'Apply to all'
  • 8b43021 Add release notes
  • e89d386 Merge branch 'master' into jfdoming/before-split-improvements
  • ea73844 Update tests to reflect change

📊 Changes

6 files changed (+12 additions, -3 deletions)

View changed files

📝 packages/desktop-client/src/components/modals/EditRule.jsx (+1 -1)
📝 packages/desktop-client/src/components/rules/RuleRow.tsx (+1 -1)
📝 packages/desktop-client/src/components/transactions/TransactionsTable.test.jsx (+2 -0)
📝 packages/loot-core/src/server/accounts/rules.ts (+1 -1)
📝 packages/loot-core/src/shared/transactions.ts (+1 -0)
➕ upcoming-release-notes/2651.md (+6 -0)

📄 Description

Two minor fixes here:

  1. category wasn't being copied from the parent transaction when creating a split. I updated this to be the case; note that this impacts manually created splits too (i.e., split an existing transaction by setting the category to "split"), but this new behaviour is actually more intuitive, IMO.
  2. Rename 'Before split' to 'Apply to all', as the latter is significantly clearer.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/2651 **Author:** [@jfdoming](https://github.com/jfdoming) **Created:** 4/21/2024 **Status:** ✅ Merged **Merged:** 4/21/2024 **Merged by:** [@youngcw](https://github.com/youngcw) **Base:** `master` ← **Head:** `jfdoming/before-split-improvements` --- ### 📝 Commits (5) - [`9fe8cd6`](https://github.com/actualbudget/actual/commit/9fe8cd6a31a7442122efdd5d2381317bded3ab88) Copy category from parent transaction when splitting - [`6e5e9fc`](https://github.com/actualbudget/actual/commit/6e5e9fcf38c08782be92e6ccec7c32079500bb69) Rename 'Before split' -> 'Apply to all' - [`8b43021`](https://github.com/actualbudget/actual/commit/8b43021b61e25138aea32057df3b0227c6f4e1bb) Add release notes - [`e89d386`](https://github.com/actualbudget/actual/commit/e89d3863308427ef448bb9771f74c75c238540b6) Merge branch 'master' into jfdoming/before-split-improvements - [`ea73844`](https://github.com/actualbudget/actual/commit/ea7384445cc8533bf34a6f986876c0f74a4ac334) Update tests to reflect change ### 📊 Changes **6 files changed** (+12 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/modals/EditRule.jsx` (+1 -1) 📝 `packages/desktop-client/src/components/rules/RuleRow.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/transactions/TransactionsTable.test.jsx` (+2 -0) 📝 `packages/loot-core/src/server/accounts/rules.ts` (+1 -1) 📝 `packages/loot-core/src/shared/transactions.ts` (+1 -0) ➕ `upcoming-release-notes/2651.md` (+6 -0) </details> ### 📄 Description Two minor fixes here: 1. `category` wasn't being copied from the parent transaction when creating a split. I updated this to be the case; note that this impacts manually created splits too (i.e., split an existing transaction by setting the category to "split"), but this new behaviour is actually more intuitive, IMO. 2. Rename 'Before split' to 'Apply to all', as the latter is significantly clearer. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-30 22:39:22 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#53738
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?