github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-10 04:02:38 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #4336] [MERGED] Fix calendar interaction when editing reports dashboard #5323

New Issue
Closed
opened 2026-02-28 21:10:34 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:10:34 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/4336
Author: @ChickenSaysBak
Created: 2/8/2025
Status: ✅ Merged
Merged: 2/11/2025
Merged by: @youngcw

Base: master ← Head: master

📝 Commits (4)

  • 13a0178 Fix calendar interaction when editing reports dashboard
  • cba99a5 Release notes
  • cf587b7 Merge branch 'master' into master
  • 5a8a401 Merge branch 'actualbudget:master' into master

📊 Changes

3 files changed (+13 additions, -0 deletions)

View changed files

📝 packages/desktop-client/src/components/reports/graphs/CalendarGraph.tsx (+3 -0)
📝 packages/desktop-client/src/components/reports/reports/CalendarCard.tsx (+4 -0)
➕ upcoming-release-notes/4336.md (+6 -0)

📄 Description

Bug

As of v25.2.1 and before, the buttons (day boxes) on calendar reports remain clickable when editing the reports dashboard. This presents a problem where the calendar is invertedly clicked on when drag-n-dropping to move it.

How to reproduce

  1. Add calendar report.
  2. Edit dashboard.
  3. Click from anywhere in the middle of the calendar (not the edges) and drag the card to a new position.
  4. Upon letting go, you will be taken to the calendar report when you should have stayed at the dashboard for further editing.

Proposed solution

This code solves the issue by sending the calendar day buttons to the background while editing the dashboard. I originally tried just disabling the buttons, but when hovering, the cursor is set to default rather than move which it should be when dragging the card.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/4336 **Author:** [@ChickenSaysBak](https://github.com/ChickenSaysBak) **Created:** 2/8/2025 **Status:** ✅ Merged **Merged:** 2/11/2025 **Merged by:** [@youngcw](https://github.com/youngcw) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (4) - [`13a0178`](https://github.com/actualbudget/actual/commit/13a01787043218f75fd9ddfa1e24e0802d005bf3) Fix calendar interaction when editing reports dashboard - [`cba99a5`](https://github.com/actualbudget/actual/commit/cba99a50f00603be7a39c9a4c7afe11ff4a5cb1c) Release notes - [`cf587b7`](https://github.com/actualbudget/actual/commit/cf587b7a16da956797a70148280545206ef6564b) Merge branch 'master' into master - [`5a8a401`](https://github.com/actualbudget/actual/commit/5a8a4018cd5ef5d39c096d8b77bdce540508d49d) Merge branch 'actualbudget:master' into master ### 📊 Changes **3 files changed** (+13 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/reports/graphs/CalendarGraph.tsx` (+3 -0) 📝 `packages/desktop-client/src/components/reports/reports/CalendarCard.tsx` (+4 -0) ➕ `upcoming-release-notes/4336.md` (+6 -0) </details> ### 📄 Description ### Bug As of v25.2.1 and before, the buttons (day boxes) on calendar reports remain clickable when editing the reports dashboard. This presents a problem where the calendar is invertedly clicked on when drag-n-dropping to move it. ### How to reproduce 1. Add calendar report. 2. Edit dashboard. 3. Click from anywhere in the middle of the calendar (not the edges) and drag the card to a new position. 4. Upon letting go, you will be taken to the calendar report when you should have stayed at the dashboard for further editing. ### Proposed solution This code solves the issue by sending the calendar day buttons to the background while editing the dashboard. I originally tried just disabling the buttons, but when hovering, the cursor is set to `default` rather than `move` which it should be when dragging the card. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:10:34 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#5323
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?