github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 03:32:54 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #2502] Fix reconciling split translations from nYNAB import creates orphan transfers #4336

New Issue
Closed
opened 2026-02-28 20:54:35 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:54:35 -06:00
Owner
Copy Link

Original Pull Request: https://github.com/actualbudget/actual/pull/2502

State: closed
Merged: Yes

Tentative fix for #2436

It is a bit more convoluted than I would like it to be, but nYNAB exports are missing several key fields on subtransactions.

The code will try to match subtransaction transfers with transaction transfers (missing the transfer_transaction_id field, which indicate that the transfer is linked to a subtransaction). Matching is made by ordering arrays of transactions and subtransactions, and trying to find matching data to store the linked ids. Unmatched data (if that should happens) will still be imported and will behave like currently in Actual.

I also streamlined payee import on transactions and subtransactions. This fix a small bug where payee on subtransactions are not imported.

**Original Pull Request:** https://github.com/actualbudget/actual/pull/2502 **State:** closed **Merged:** Yes --- Tentative fix for #2436 It is a bit more convoluted than I would like it to be, but nYNAB exports are missing several key fields on subtransactions. The code will try to match subtransaction transfers with transaction transfers (missing the transfer_transaction_id field, which indicate that the transfer is linked to a subtransaction). Matching is made by ordering arrays of transactions and subtransactions, and trying to find matching data to store the linked ids. Unmatched data (if that should happens) will still be imported and will behave like currently in Actual. I also streamlined payee import on transactions and subtransactions. This fix a small bug where payee on subtransactions are not imported. <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes -->
GiteaMirror added the pull-request label 2026-02-28 20:54:36 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#4336
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?