mirror of
https://github.com/actualbudget/actual.git
synced 2026-03-11 04:32:39 -05:00
[PR #3878] [MERGED] OpenId Implementation #5106
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/actual#5106
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/actualbudget/actual/pull/3878
Author: @lelemm
Created: 11/22/2024
Status: ✅ Merged
Merged: 12/23/2024
Merged by: @youngcw
Base:
master← Head:openid_squashed📝 Commits (10+)
5a65c68OpenId implementation45e855eCode rabbit auto generated code applied29458e1Code rabbit suggestions round 20a7ab28fixes from code rabbit round 1a60768cMerge branch 'openid_squashed' of https://github.com/lelemm/actual into openid_squashed161a89dfixes from code rabbit round 2247626echange variable name75384b0code review round 3cfc94abUpdate VRTcbbe12bMerge branch 'master' into openid_squashed📊 Changes
73 files changed (+4835 additions, -391 deletions)
View changed files
📝
packages/api/methods.ts(+4 -1)📝
packages/desktop-client/e2e/settings.test.js-snapshots/Settings-checks-the-page-visuals-1-chromium-linux.png(+0 -0)📝
packages/desktop-client/e2e/settings.test.js-snapshots/Settings-checks-the-page-visuals-3-chromium-linux.png(+0 -0)➕
packages/desktop-client/src/auth/AuthProvider.tsx(+48 -0)➕
packages/desktop-client/src/auth/ProtectedRoute.tsx(+65 -0)➕
packages/desktop-client/src/auth/types.ts(+3 -0)📝
packages/desktop-client/src/browser-preload.browser.js(+2 -0)📝
packages/desktop-client/src/components/App.tsx(+21 -1)📝
packages/desktop-client/src/components/FinancesApp.tsx(+30 -1)📝
packages/desktop-client/src/components/LoggedInUser.tsx(+121 -24)📝
packages/desktop-client/src/components/ManageRules.tsx(+1 -1)📝
packages/desktop-client/src/components/Modals.tsx(+41 -0)📝
packages/desktop-client/src/components/ServerContext.tsx(+88 -1)➕
packages/desktop-client/src/components/admin/UserAccess/UserAccess.tsx(+292 -0)➕
packages/desktop-client/src/components/admin/UserAccess/UserAccessHeader.tsx(+16 -0)➕
packages/desktop-client/src/components/admin/UserAccess/UserAccessPage.tsx(+22 -0)➕
packages/desktop-client/src/components/admin/UserAccess/UserAccessRow.tsx(+148 -0)➕
packages/desktop-client/src/components/admin/UserDirectory/UserDirectory.tsx(+370 -0)➕
packages/desktop-client/src/components/admin/UserDirectory/UserDirectoryHeader.tsx(+34 -0)➕
packages/desktop-client/src/components/admin/UserDirectory/UserDirectoryPage.tsx(+49 -0)...and 53 more files
📄 Description
Following the PR #1164
Instruction on how to test this.
Clone actual server PR and this PR locally, at the server, in the packages.json, point the @actual/web to link to this PR clone (this is important because the pages will come from this package)
This is how I do:
It's important to remember to BUILD the desktop-client package before starting the server.
I suggest to start testing this using a empty server instead of an server already configured.
Once you have actual server running, you can open the URL and start configuring it using this preview doc https://deploy-preview-447.www.actualbudget.org/docs/advanced/oauth-auth
I suggest start with configuring from bootstrap. Use passwordless.id for testing, probably the easiest way to test.
You can test the openid provider login now. But to test multiple users, you have to configure multiuser support
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.