github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-10 12:12:39 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #3805] [MERGED] Enactment: enable triggering of rules on selected transaction form the account view. #5068

New Issue
Closed
opened 2026-02-28 21:05:27 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:05:27 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/3805
Author: @esseti
Created: 11/8/2024
Status: ✅ Merged
Merged: 1/12/2025
Merged by: @UnderKoen

Base: master ← Head: master

📝 Commits (10+)

  • 9fcd93e Adding functionality to trigger the rules of transaction from the transaction view
  • f857d26 fix warnings
  • cccc730 Merge remote-tracking branch 'origin/master'
  • a27e6d0 Fixing errors on the checks: adding changelog and lint
  • a7861a8 Applying suggestion from the bot.
  • 08350b5 Merge remote-tracking branch 'original/master'
  • 01af7fe ✨ Enhance transaction processing in Account component by implementing rules execution and batch updates. Added utility function imports for improved functionality.
  • 5c520d1 Update packages/desktop-client/src/components/accounts/Account.tsx
  • 7518e0a Merge branch 'master' into master
  • b201f3c Refactor Account component imports by removing unused utility functions for cleaner code.

📊 Changes

4 files changed (+57 additions, -0 deletions)

View changed files

📝 packages/desktop-client/src/components/accounts/Account.tsx (+38 -0)
📝 packages/desktop-client/src/components/accounts/Header.tsx (+3 -0)
📝 packages/desktop-client/src/components/transactions/SelectedTransactionsButton.tsx (+10 -0)
➕ upcoming-release-notes/3805.md (+6 -0)

📄 Description

The PR implements the use case described here: https://github.com/actualbudget/actual/issues/3244

It enables the possibility to have the rules triggered from the account view. Via the dropdown menu or by pressing the letter R

image

Note: this is my first PR here and this is the first time that i code something in TypeScript and React.
Please ensure the following when merging:

  • The function I wrote is in the correct file.
  • It is acceptable to send API calls in this manner. Note that this approach is "inspired" by the code in the popup for editing rules that permit a similar behavior.
  • The method used to "refetch" transactions is appropriate and not too burdensome. I would have preferred to refetch only the edited transaction, but I was unable to find a way, and the API call does not return the transaction edited after the rules have been applied.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/3805 **Author:** [@esseti](https://github.com/esseti) **Created:** 11/8/2024 **Status:** ✅ Merged **Merged:** 1/12/2025 **Merged by:** [@UnderKoen](https://github.com/UnderKoen) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (10+) - [`9fcd93e`](https://github.com/actualbudget/actual/commit/9fcd93e350e46b891eeeca9a201c2d32f3405ea7) Adding functionality to trigger the rules of transaction from the transaction view - [`f857d26`](https://github.com/actualbudget/actual/commit/f857d26e478869e8e4671679f5125f522896644a) fix warnings - [`cccc730`](https://github.com/actualbudget/actual/commit/cccc7305f2edc5ded2f96a7073dfced0c1e7af27) Merge remote-tracking branch 'origin/master' - [`a27e6d0`](https://github.com/actualbudget/actual/commit/a27e6d02de885f8edaa1c98790847e98108ec49a) Fixing errors on the checks: adding changelog and lint - [`a7861a8`](https://github.com/actualbudget/actual/commit/a7861a8cbfefbd6c9d583c8f69b78821cb39ba76) Applying suggestion from the bot. - [`08350b5`](https://github.com/actualbudget/actual/commit/08350b5f7fa1cfc90f09fd446799644b605c636c) Merge remote-tracking branch 'original/master' - [`01af7fe`](https://github.com/actualbudget/actual/commit/01af7fe8036285c1905a8a4c15c5256a11e21cd1) ✨ Enhance transaction processing in Account component by implementing rules execution and batch updates. Added utility function imports for improved functionality. - [`5c520d1`](https://github.com/actualbudget/actual/commit/5c520d192ae09020507a1a4a19b92fdfa1d5fe27) Update packages/desktop-client/src/components/accounts/Account.tsx - [`7518e0a`](https://github.com/actualbudget/actual/commit/7518e0a8f33946e546ad69ff065e09591bb9ff08) Merge branch 'master' into master - [`b201f3c`](https://github.com/actualbudget/actual/commit/b201f3c72cec506d0a594507e2704147394c7726) Refactor Account component imports by removing unused utility functions for cleaner code. ### 📊 Changes **4 files changed** (+57 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/accounts/Account.tsx` (+38 -0) 📝 `packages/desktop-client/src/components/accounts/Header.tsx` (+3 -0) 📝 `packages/desktop-client/src/components/transactions/SelectedTransactionsButton.tsx` (+10 -0) ➕ `upcoming-release-notes/3805.md` (+6 -0) </details> ### 📄 Description The PR implements the use case described here: https://github.com/actualbudget/actual/issues/3244 It enables the possibility to have the rules triggered from the account view. Via the dropdown menu or by pressing the letter `R` ![image](https://github.com/user-attachments/assets/48d50fa7-06c3-4a86-86f9-b1d7a5aca062) *Note*: this is my first PR here and this is the first time that i code something in TypeScript and React. Please ensure the following when merging: - The function I wrote is in the correct file. - It is acceptable to send API calls in this manner. Note that this approach is "inspired" by the code in the popup for editing rules that permit a similar behavior. - The method used to "refetch" transactions is appropriate and not too burdensome. I would have preferred to refetch only the edited transaction, but I was unable to find a way, and the API call does not return the transaction edited after the rules have been applied. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:05:27 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#5068
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?