github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-11 04:32:39 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #3736] [MERGED] 🐛 Extra error handling for if user has incorrect server url #5030

New Issue
Closed
opened 2026-02-28 21:04:54 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:04:54 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/3736
Author: @MikesGlitch
Created: 10/25/2024
Status: ✅ Merged
Merged: 10/26/2024
Merged by: @MikesGlitch

Base: master ← Head: electron/fix-incorrect-server-url

📝 Commits (4)

  • 1cd81f9 adding some safety for if user has incorrect server url format
  • 0a02249 added additional error handling for when incorrect server url has been setup
  • bc7c1b2 Merge branch 'master' into electron/fix-incorrect-server-url
  • e269cc4 good rabbit

📊 Changes

2 files changed (+22 additions, -7 deletions)

View changed files

📝 packages/loot-core/src/server/server-config.ts (+16 -7)
➕ upcoming-release-notes/3736.md (+6 -0)

📄 Description

Issue: https://discord.com/channels/937901803608096828/1299188124621996082

If server URL is unable to be parsed we need to handle it gracefully. We do this by returning the server url paths as if no url was specified (because we don't have a correct url).

This should prevent us getting into a hang state where it's unable to load the main process.

image

image

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/3736 **Author:** [@MikesGlitch](https://github.com/MikesGlitch) **Created:** 10/25/2024 **Status:** ✅ Merged **Merged:** 10/26/2024 **Merged by:** [@MikesGlitch](https://github.com/MikesGlitch) **Base:** `master` ← **Head:** `electron/fix-incorrect-server-url` --- ### 📝 Commits (4) - [`1cd81f9`](https://github.com/actualbudget/actual/commit/1cd81f939c2f36969dd0c0ac508d6105ba4750a5) adding some safety for if user has incorrect server url format - [`0a02249`](https://github.com/actualbudget/actual/commit/0a022494794fe65c9cd7f49fb4a355642e4f0e63) added additional error handling for when incorrect server url has been setup - [`bc7c1b2`](https://github.com/actualbudget/actual/commit/bc7c1b29a0d54b5493d3032479ec4c60f71c5b46) Merge branch 'master' into electron/fix-incorrect-server-url - [`e269cc4`](https://github.com/actualbudget/actual/commit/e269cc496fb97006fe9438fbe3915cedeb5d88ee) good rabbit ### 📊 Changes **2 files changed** (+22 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `packages/loot-core/src/server/server-config.ts` (+16 -7) ➕ `upcoming-release-notes/3736.md` (+6 -0) </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes --> Issue: https://discord.com/channels/937901803608096828/1299188124621996082 If server URL is unable to be parsed we need to handle it gracefully. We do this by returning the server url paths as if no url was specified (because we don't have a correct url). This should prevent us getting into a hang state where it's unable to load the main process. ![image](https://github.com/user-attachments/assets/c0aabc05-841c-488e-a8c6-30b478da90ca) ![image](https://github.com/user-attachments/assets/1fe0362b-aae2-4d5d-afc3-2714af5e0052) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:04:54 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#5030
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?