[PR #1431] [MERGED] Move big input component into Input.js, port some of the manager app to TS #3736

Closed
opened 2026-02-28 20:45:59 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/1431
Author: @j-f1
Created: 7/31/2023
Status: Merged
Merged: 8/4/2023
Merged by: @MatissJanis

Base: masterHead: jed/big-input


📝 Commits (7)

📊 Changes

9 files changed (+74 additions, -61 deletions)

View changed files

📝 packages/desktop-client/src/components/ServerContext.tsx (+21 -7)
📝 packages/desktop-client/src/components/common/Input.tsx (+20 -4)
📝 packages/desktop-client/src/components/manager/ConfigServer.tsx (+13 -14)
📝 packages/desktop-client/src/components/manager/ServerURL.tsx (+1 -1)
📝 packages/desktop-client/src/components/manager/subscribe/ConfirmPasswordForm.tsx (+3 -4)
📝 packages/desktop-client/src/components/manager/subscribe/Login.tsx (+3 -2)
📝 packages/desktop-client/src/components/manager/subscribe/common.tsx (+2 -27)
📝 packages/loot-core/src/types/server-handlers.d.ts (+5 -2)
upcoming-release-notes/1431.md (+6 -0)

📄 Description


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/1431 **Author:** [@j-f1](https://github.com/j-f1) **Created:** 7/31/2023 **Status:** ✅ Merged **Merged:** 8/4/2023 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `jed/big-input` --- ### 📝 Commits (7) - [`5f22e99`](https://github.com/actualbudget/actual/commit/5f22e99a50eb9a341ca4aba231a2447bf77698c2) Remove unneded forwardRef - [`d5d65c2`](https://github.com/actualbudget/actual/commit/d5d65c20a918d4893866c3f0bd6e51d8ff2f9d69) Rename subscribe input to BigInput & move to Input.tsx - [`b9410b5`](https://github.com/actualbudget/actual/commit/b9410b545b53f9e7e07e019c6cb37c68974b2063) Port ServerContext to TS - [`2261a9e`](https://github.com/actualbudget/actual/commit/2261a9e1ad4a84f9d78ae82fa18e49eff175f1f8) Port ConfigServer to TS - [`9c7f6bc`](https://github.com/actualbudget/actual/commit/9c7f6bce31d3745d40cfcba3b3001123c476d769) Port ServerURL to TS - [`40df00b`](https://github.com/actualbudget/actual/commit/40df00bea0594d3104027c748296832d3b43c6cc) Fix lint issues - [`e4c6b77`](https://github.com/actualbudget/actual/commit/e4c6b77f367a5f03d7617495c521013108ffa2e6) Add release note ### 📊 Changes **9 files changed** (+74 additions, -61 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/ServerContext.tsx` (+21 -7) 📝 `packages/desktop-client/src/components/common/Input.tsx` (+20 -4) 📝 `packages/desktop-client/src/components/manager/ConfigServer.tsx` (+13 -14) 📝 `packages/desktop-client/src/components/manager/ServerURL.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/manager/subscribe/ConfirmPasswordForm.tsx` (+3 -4) 📝 `packages/desktop-client/src/components/manager/subscribe/Login.tsx` (+3 -2) 📝 `packages/desktop-client/src/components/manager/subscribe/common.tsx` (+2 -27) 📝 `packages/loot-core/src/types/server-handlers.d.ts` (+5 -2) ➕ `upcoming-release-notes/1431.md` (+6 -0) </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:45:59 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#3736