github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 07:01:45 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[GH-ISSUE #2644] [Bug]: Transaction Edit menu shortcuts have poor contrast in dark mode (and lesser so in midnight) #50171

New Issue
Closed
opened 2026-04-30 13:26:00 -05:00 by GiteaMirror · 2 comments
GiteaMirror commented 2026-04-30 13:26:00 -05:00
Owner
Copy Link

Originally created by @Teprifer on GitHub (Apr 20, 2024).
Original GitHub issue: https://github.com/actualbudget/actual/issues/2644

Verified issue does not already exist?

  • I have searched and found no existing issue
  • I will be providing steps how to reproduce the bug (in most cases this will also mean uploading a demo budget file)

What happened?

Referring to the short cut letters on the right side of the transaction edit menu.

If the shortcut for Show wasn't F they could be done away with entirely by underlining their respective short cut letter in the action name itself.

Light for comparison:
image

Dark (very poor contrast):
image

Midnight (poor contrast):
image

Generally, I think the size of these could be improved which would aid, but improving contrast should help with discoverability enough.

Where are you hosting Actual?

Docker

What browsers are you seeing the problem on?

Firefox, Chrome

Operating System

Windows 11

Originally created by @Teprifer on GitHub (Apr 20, 2024). Original GitHub issue: https://github.com/actualbudget/actual/issues/2644 ### Verified issue does not already exist? - [X] I have searched and found no existing issue - [X] I will be providing steps how to reproduce the bug (in most cases this will also mean uploading a demo budget file) ### What happened? Referring to the short cut letters on the right side of the transaction edit menu. If the shortcut for Show wasn't F they could be done away with entirely by underlining their respective short cut letter in the action name itself. Light for comparison: ![image](https://github.com/actualbudget/actual/assets/34882928/488929b7-5400-44b5-9029-5242478cf764) Dark (very poor contrast): ![image](https://github.com/actualbudget/actual/assets/34882928/de5f1e95-9faa-4bd7-b3bd-94025e41f4be) Midnight (poor contrast): ![image](https://github.com/actualbudget/actual/assets/34882928/42a0e5c0-f59c-402f-a641-e1a979ad3828) Generally, I think the size of these could be improved which would aid, but improving contrast should help with discoverability enough. ### Where are you hosting Actual? Docker ### What browsers are you seeing the problem on? Firefox, Chrome ### Operating System Windows 11
GiteaMirror added the bug label 2026-04-30 13:26:00 -05:00
GiteaMirror commented 2026-04-30 13:26:12 -05:00
Author
Owner
Copy Link

@sierikov commented on GitHub (Apr 25, 2024):

With current colors, it is nearly impossible to make the color contrast and accent at the same time. The boundary for acceptable contrast ratios lies in the zone left from the white lines on the provided image. Any area to the right of these lines is deemed "unreadable."

Screenshot 2024-04-25 at 14 56 38

To achieve the desired contrast ratio we must:

  • choose another accent color or background, or
  • refactor the dropdown, so the titles of subsections don't depend on the color.

I have experimented with the colors and forms of the menu. The results please see below:

Modified subsection header:
Screenshot 2024-04-25 at 15 15 57

Please let me know what you think

<!-- gh-comment-id:2077165170 --> @sierikov commented on GitHub (Apr 25, 2024): With current colors, it is nearly impossible to make the color contrast and accent at the same time. The boundary for acceptable contrast ratios lies in the zone left from the white lines on the provided image. Any area to the right of these lines is deemed "unreadable." <img width="237" alt="Screenshot 2024-04-25 at 14 56 38" src="https://github.com/actualbudget/actual/assets/22551739/925cd877-32b2-445d-97ee-a91bfab315a4"> To achieve the desired contrast ratio we must: - choose another accent color or background, or - refactor the dropdown, so the titles of subsections don't depend on the color. I have experimented with the colors and forms of the menu. The results please see below: Modified subsection header: <img width="302" alt="Screenshot 2024-04-25 at 15 15 57" src="https://github.com/actualbudget/actual/assets/22551739/355bedb9-fb61-4b66-8ab1-91ef636d787e"> Please let me know what you think
GiteaMirror commented 2026-04-30 13:26:13 -05:00
Author
Owner
Copy Link

@Teprifer commented on GitHub (Apr 25, 2024):

@sierikov Were you thinking of #2638 ?

This is a bug report for the same menu, but specifically the shortcut letters on the right side, not the menu headers themselves.

It was reading the other one which reminded me I hadn't created a bug report for this issue.

<!-- gh-comment-id:2077182750 --> @Teprifer commented on GitHub (Apr 25, 2024): @sierikov Were you thinking of #2638 ? This is a bug report for the same menu, but specifically the shortcut letters on the right side, not the menu headers themselves. It was reading the other one which reminded me I hadn't created a bug report for this issue.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#50171
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?