github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-10 12:12:39 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #3600] [MERGED] :electron: Migrations out of sync modal #4948

New Issue
Closed
opened 2026-02-28 21:03:40 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:03:40 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/3600
Author: @MikesGlitch
Created: 10/7/2024
Status: ✅ Merged
Merged: 10/10/2024
Merged by: @MikesGlitch

Base: master ← Head: electron/client-version-out-of-sync

📝 Commits (10+)

📊 Changes

5 files changed (+105 additions, -10 deletions)

View changed files

📝 packages/desktop-client/src/components/Modals.tsx (+3 -9)
➕ packages/desktop-client/src/components/modals/OutOfSyncMigrationsModal.tsx (+91 -0)
📝 packages/loot-core/src/client/actions/budgets.ts (+3 -1)
📝 packages/loot-core/src/client/state-types/modals.d.ts (+2 -0)
➕ upcoming-release-notes/3600.md (+6 -0)

📄 Description

When will this display?

When you have multiple clients using one server. One client has been updated, the other hasn't. The updated client runs on the budget and migrates the data to the latest. Then the out-of-date client opens the budget.

We shouldn't let the user continue using the client in case they end up with bad data. It's not worth the risk. We should warn the user about it, prompt them to update their client, and let them know it's possible to use the web app from app.actualbudget.org.

image

Original intention

This was intended to be a warning for when server is a different version from client. I couldn't do it because

  • we'd need to force the user to be online and connect to the server to get the version info.
  • the user would have to wait until the server responds before loading the budget.

I don't think we should do that so I had to bin the idea.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/3600 **Author:** [@MikesGlitch](https://github.com/MikesGlitch) **Created:** 10/7/2024 **Status:** ✅ Merged **Merged:** 10/10/2024 **Merged by:** [@MikesGlitch](https://github.com/MikesGlitch) **Base:** `master` ← **Head:** `electron/client-version-out-of-sync` --- ### 📝 Commits (10+) - [`013f53b`](https://github.com/actualbudget/actual/commit/013f53b1a5199e03b663bb555889227b6fce76b1) add a modal to say client is wrong version, accept the risks to continue using - [`e8e1dfd`](https://github.com/actualbudget/actual/commit/e8e1dfd893b5953dc2a8ec84cde0e9ae889c7a99) Merge branch 'master' of https://github.com/MikesGlitch/actual into electron/client-version-out-of-sync - [`a21cc28`](https://github.com/actualbudget/actual/commit/a21cc2834b9d34b0367777ae27b599889a868457) user friendly error - [`f08d0ed`](https://github.com/actualbudget/actual/commit/f08d0ed6f860556184c966378b7fdafc120c2d1e) hooking parts up - untested - [`cd260bd`](https://github.com/actualbudget/actual/commit/cd260bd990010c187b03af8e90564f0164574b4f) changed approach - [`d8f4208`](https://github.com/actualbudget/actual/commit/d8f42081ca5ee25d94677a1b9fb72beefd9febe3) release notes - [`ee7d982`](https://github.com/actualbudget/actual/commit/ee7d9821308f4d6c5a039a1b9785fc0a8433011e) Merge branch 'master' of https://github.com/MikesGlitch/actual into electron/client-version-out-of-sync - [`e0ba62b`](https://github.com/actualbudget/actual/commit/e0ba62ba7a8fbf9bf68670c874beabe79bcf16a9) removing old comments - [`dc2881d`](https://github.com/actualbudget/actual/commit/dc2881de4c53eea1ecc7c736a2b485bda6c2f5f9) cleanup old code - [`a478899`](https://github.com/actualbudget/actual/commit/a478899165863586581b21c2d483290f824ab90c) feedback ### 📊 Changes **5 files changed** (+105 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/Modals.tsx` (+3 -9) ➕ `packages/desktop-client/src/components/modals/OutOfSyncMigrationsModal.tsx` (+91 -0) 📝 `packages/loot-core/src/client/actions/budgets.ts` (+3 -1) 📝 `packages/loot-core/src/client/state-types/modals.d.ts` (+2 -0) ➕ `upcoming-release-notes/3600.md` (+6 -0) </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes --> # When will this display? When you have multiple clients using one server. One client has been updated, the other hasn't. The updated client runs on the budget and migrates the data to the latest. Then the out-of-date client opens the budget. We shouldn't let the user continue using the client in case they end up with bad data. It's not worth the risk. We should warn the user about it, prompt them to update their client, and let them know it's possible to use the web app from app.actualbudget.org. ![image](https://github.com/user-attachments/assets/3694ea42-397d-49f2-8971-5b4c4134a94f) ## Original intention This was intended to be a **warning for when server is a different version from client**. I couldn't do it because - we'd need to force the user to be online and connect to the server to get the version info. - the user would have to wait until the server responds before loading the budget. I don't think we should do that so I had to bin the idea. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:03:40 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#4948
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?