github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-10 04:02:38 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #1217] [MERGED] Move the rest of the syncing protobuf code to the CRDT package #3600

New Issue
Closed
opened 2026-02-28 20:44:02 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:44:02 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/1217
Author: @j-f1
Created: 6/28/2023
Status: ✅ Merged
Merged: 6/28/2023
Merged by: @j-f1

Base: master ← Head: jed/mv-protoc

📝 Commits (10+)

  • 9a26fc1 Move protobuf-related code into crdt
  • 66fad35 Re-generate
  • e3d1939 Run Prettier on the .d.ts, ask user to fix declaration
  • 778e390 Better scarier README
  • 433b09e Add an npm script to call protoc
  • 655ba6b move Message type into CRDT package
  • 3a74c04 Move encryption/encoder to CRDT package
  • 1137a12 Swap to an object param because it was getting hard to understand
  • 2ac8de7 Add release note
  • 82e4ef0 Revert additional changes

📊 Changes

10 files changed (+88 additions, -54 deletions)

View changed files

➕ .prettierignore (+1 -0)
➕ packages/crdt/.gitignore (+2 -0)
📝 packages/crdt/README.md (+8 -15)
➕ packages/crdt/bin/generate-proto (+21 -0)
📝 packages/crdt/package.json (+2 -0)
📝 packages/crdt/src/proto/sync.proto (+0 -0)
📝 packages/crdt/src/proto/sync_pb.d.ts (+47 -37)
📝 packages/loot-core/package.json (+0 -1)
➕ upcoming-release-notes/1217.md (+6 -0)
📝 yarn.lock (+1 -1)

📄 Description

Fixes #1188.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/1217 **Author:** [@j-f1](https://github.com/j-f1) **Created:** 6/28/2023 **Status:** ✅ Merged **Merged:** 6/28/2023 **Merged by:** [@j-f1](https://github.com/j-f1) **Base:** `master` ← **Head:** `jed/mv-protoc` --- ### 📝 Commits (10+) - [`9a26fc1`](https://github.com/actualbudget/actual/commit/9a26fc1831e6cc3dce0365630c93333c97c89eac) Move protobuf-related code into crdt - [`66fad35`](https://github.com/actualbudget/actual/commit/66fad35ab366bc62ed37b61ea66b8946d64923e8) Re-generate - [`e3d1939`](https://github.com/actualbudget/actual/commit/e3d1939c9ddb97e012247fa9b995b5509a7fed77) Run Prettier on the .d.ts, ask user to fix declaration - [`778e390`](https://github.com/actualbudget/actual/commit/778e390ce0e93010264232d48d3ea06bb1997d9c) Better scarier README - [`433b09e`](https://github.com/actualbudget/actual/commit/433b09e19b7e4be5147ff9c4342b3a59dd87df69) Add an npm script to call protoc - [`655ba6b`](https://github.com/actualbudget/actual/commit/655ba6b46b542d9470472079f40409282f4d4a6b) move Message type into CRDT package - [`3a74c04`](https://github.com/actualbudget/actual/commit/3a74c04cd499f5d30f10d0272eb7af016e3ea88e) Move encryption/encoder to CRDT package - [`1137a12`](https://github.com/actualbudget/actual/commit/1137a122eb472ebda5b34aebadc97f9e5e6ae736) Swap to an object param because it was getting hard to understand - [`2ac8de7`](https://github.com/actualbudget/actual/commit/2ac8de7140f3a90177afe6d5ef1d05b7c35e7a12) Add release note - [`82e4ef0`](https://github.com/actualbudget/actual/commit/82e4ef0dc377aa0c03f1cfe842f9ee7eefc58db4) Revert additional changes ### 📊 Changes **10 files changed** (+88 additions, -54 deletions) <details> <summary>View changed files</summary> ➕ `.prettierignore` (+1 -0) ➕ `packages/crdt/.gitignore` (+2 -0) 📝 `packages/crdt/README.md` (+8 -15) ➕ `packages/crdt/bin/generate-proto` (+21 -0) 📝 `packages/crdt/package.json` (+2 -0) 📝 `packages/crdt/src/proto/sync.proto` (+0 -0) 📝 `packages/crdt/src/proto/sync_pb.d.ts` (+47 -37) 📝 `packages/loot-core/package.json` (+0 -1) ➕ `upcoming-release-notes/1217.md` (+6 -0) 📝 `yarn.lock` (+1 -1) </details> ### 📄 Description Fixes #1188. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:44:02 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#3600
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?