github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-10 04:02:38 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #3500] [CLOSED] :electron: Move file settings to the file management area #4890

New Issue
Closed
opened 2026-02-28 21:02:48 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:02:48 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/3500
Author: @MikesGlitch
Created: 9/24/2024
Status: ❌ Closed

Base: master ← Head: electron/file-management-settings

📝 Commits (10+)

📊 Changes

17 files changed (+570 additions, -80 deletions)

View changed files

📝 packages/desktop-client/src/browser-preload.browser.js (+2 -0)
📝 packages/desktop-client/src/components/Modals.tsx (+12 -0)
📝 packages/desktop-client/src/components/alerts.tsx (+1 -1)
📝 packages/desktop-client/src/components/manager/BudgetList.tsx (+38 -2)
➕ packages/desktop-client/src/components/modals/manager/ConfirmChangeDocumentDir.tsx (+208 -0)
➕ packages/desktop-client/src/components/modals/manager/FilesSettingsModal.tsx (+190 -0)
➕ packages/desktop-client/src/components/settings/Backups.tsx (+31 -0)
➖ packages/desktop-client/src/components/settings/Global.tsx (+0 -73)
📝 packages/desktop-client/src/components/settings/index.tsx (+3 -3)
📝 packages/desktop-electron/index.ts (+30 -0)
📝 packages/desktop-electron/package.json (+2 -0)
📝 packages/desktop-electron/preload.ts (+11 -0)
📝 packages/loot-core/src/client/state-types/modals.d.ts (+7 -0)
📝 packages/loot-core/src/server/main.ts (+3 -0)
📝 packages/loot-core/typings/window.d.ts (+4 -0)
➕ upcoming-release-notes/3500.md (+6 -0)
📝 yarn.lock (+22 -1)

📄 Description

This is step 1 to resolving this issue: #3371

  • Added settings modal into file management page and moved the Change data dir functionality in
  • Provided an option to automatically move budget files as a part of changing data dir
  • Silently restart electron server when Actuals data dir is changed and refreshes data, preventing the need for a hard restart.
  • Adding info about Electrons backups (telling users that it exists or how often it runs)

Step 2 is to allow configuration before creating a budget (will tackle that in a follow up PR).

Changing the data directory

test3

Settings page (if electron):

image

Tested on:

  • Windows
  • Linux
  • Mac

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/3500 **Author:** [@MikesGlitch](https://github.com/MikesGlitch) **Created:** 9/24/2024 **Status:** ❌ Closed **Base:** `master` ← **Head:** `electron/file-management-settings` --- ### 📝 Commits (10+) - [`f5c2f8e`](https://github.com/actualbudget/actual/commit/f5c2f8e1f29d3901515baedbd830d653528db69f) move settings to the file management area - [`212a79e`](https://github.com/actualbudget/actual/commit/212a79efb713938d62076d55dc2b168c39d010ed) more settings - [`1015428`](https://github.com/actualbudget/actual/commit/1015428bcb3859323065c5102cd6d61af9c73a08) giving users option to automatically move files when changing dir - [`847fbde`](https://github.com/actualbudget/actual/commit/847fbde40cf8f6a21a0afe561a1cf02082468a1d) trueee - [`2d50348`](https://github.com/actualbudget/actual/commit/2d50348842702291361dbfc254f6efc2932acecd) updates - [`7b7f26b`](https://github.com/actualbudget/actual/commit/7b7f26beb8edc4d28d1fe98d082f7298e579fe4d) does this fix the type issue - [`2470bf8`](https://github.com/actualbudget/actual/commit/2470bf87049c5f55174aa26d12020e312f647348) weird - [`f030f06`](https://github.com/actualbudget/actual/commit/f030f06a3a0365d2892f53a9b5c4804f96b3a8a8) translating - [`ed17ca1`](https://github.com/actualbudget/actual/commit/ed17ca190e926c8429fc3a372a44fcb79fb97a9f) release notes - [`f02837c`](https://github.com/actualbudget/actual/commit/f02837c48136f78a9237918894b8d15518b810ac) release notes ### 📊 Changes **17 files changed** (+570 additions, -80 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/browser-preload.browser.js` (+2 -0) 📝 `packages/desktop-client/src/components/Modals.tsx` (+12 -0) 📝 `packages/desktop-client/src/components/alerts.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/manager/BudgetList.tsx` (+38 -2) ➕ `packages/desktop-client/src/components/modals/manager/ConfirmChangeDocumentDir.tsx` (+208 -0) ➕ `packages/desktop-client/src/components/modals/manager/FilesSettingsModal.tsx` (+190 -0) ➕ `packages/desktop-client/src/components/settings/Backups.tsx` (+31 -0) ➖ `packages/desktop-client/src/components/settings/Global.tsx` (+0 -73) 📝 `packages/desktop-client/src/components/settings/index.tsx` (+3 -3) 📝 `packages/desktop-electron/index.ts` (+30 -0) 📝 `packages/desktop-electron/package.json` (+2 -0) 📝 `packages/desktop-electron/preload.ts` (+11 -0) 📝 `packages/loot-core/src/client/state-types/modals.d.ts` (+7 -0) 📝 `packages/loot-core/src/server/main.ts` (+3 -0) 📝 `packages/loot-core/typings/window.d.ts` (+4 -0) ➕ `upcoming-release-notes/3500.md` (+6 -0) 📝 `yarn.lock` (+22 -1) </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes --> This is **step 1** to resolving this issue: #3371 - Added settings modal into file management page and moved the _Change data dir_ functionality in - Provided an option to automatically move budget files as a part of changing data dir - Silently restart electron server when Actuals data dir is changed and refreshes data, preventing the need for a hard restart. - Adding info about Electrons backups (telling users that it exists or how often it runs) **Step 2** is to allow configuration before creating a budget (will tackle that in a follow up PR). **Changing the data directory** ![test3](https://github.com/user-attachments/assets/3e4bf62f-775e-4408-9fb8-5756ae032ffe) **Settings page (if electron):** ![image](https://github.com/user-attachments/assets/24b3b51a-c1ab-4e36-a96b-6c4da6488b1a) **Tested on:** - [x] Windows - [x] Linux - [x] Mac --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:02:49 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#4890
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?