github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-22 12:30:06 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #860] [MERGED] Allow goal template 'by' matches to compound #3371

New Issue
Closed
opened 2026-02-28 20:40:37 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:40:37 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/860
Author: @shall0pass
Created: 4/6/2023
Status: ✅ Merged
Merged: 4/7/2023
Merged by: @j-f1

Base: master ← Head: goals_compoundingBys

📝 Commits (3)

  • 802be13 Allow goal template 'by' matches to compound
  • c752cb1 release notes
  • 9dc854d Merge branch 'actualbudget:master' into goals_compoundingBys

📊 Changes

2 files changed (+16 additions, -24 deletions)

View changed files

📝 packages/loot-core/src/server/budget/goaltemplates.js (+10 -24)
➕ upcoming-release-notes/860.md (+6 -0)

📄 Description

I believe this change allows for having multiple 'by' rules in the same category. It seems to be working well for my purposes, but I would appreciate further testing to assure there aren't regressions.

Example:

#template 300 by 2023-06
#template 3000 by 2023-08

Before this PR, having these two lines in the notes would only budget funds for the earliest of the two strings and ignore the 3000 funding target. With this PR, the sum of the two funding targets will be respected.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/860 **Author:** [@shall0pass](https://github.com/shall0pass) **Created:** 4/6/2023 **Status:** ✅ Merged **Merged:** 4/7/2023 **Merged by:** [@j-f1](https://github.com/j-f1) **Base:** `master` ← **Head:** `goals_compoundingBys` --- ### 📝 Commits (3) - [`802be13`](https://github.com/actualbudget/actual/commit/802be13b409d9c02386203a19267bb57996f9eac) Allow goal template 'by' matches to compound - [`c752cb1`](https://github.com/actualbudget/actual/commit/c752cb11879887033206f01fd46ad94e681e2096) release notes - [`9dc854d`](https://github.com/actualbudget/actual/commit/9dc854d53d3eac6764fb7e1dff301e36f2b820d6) Merge branch 'actualbudget:master' into goals_compoundingBys ### 📊 Changes **2 files changed** (+16 additions, -24 deletions) <details> <summary>View changed files</summary> 📝 `packages/loot-core/src/server/budget/goaltemplates.js` (+10 -24) ➕ `upcoming-release-notes/860.md` (+6 -0) </details> ### 📄 Description I believe this change allows for having multiple 'by' rules in the same category. It seems to be working well for my purposes, but I would appreciate further testing to assure there aren't regressions. Example: #template 300 by 2023-06 #template 3000 by 2023-08 Before this PR, having these two lines in the notes would only budget funds for the earliest of the two strings and ignore the 3000 funding target. With this PR, the sum of the two funding targets will be respected. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:40:37 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#3371
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?