github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 11:42:54 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #1001] [MERGED] Remove “needs votes” label from feature requests that have been implemented #3458

New Issue
Closed
opened 2026-02-28 20:41:57 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:41:57 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/1001
Author: @j-f1
Created: 5/5/2023
Status: ✅ Merged
Merged: 5/6/2023
Merged by: @j-f1

Base: master ← Head: jed/actions-maintenance

📝 Commits (10+)

  • 6a0e26e Merge release notes actions into one
  • 8a56abf Only add the needs triage label if there are no labels
  • 9fb68b3 Rename stale workflow to match with other issues actions
  • ad44359 Merge test, lint, & typecheck into one workflow
  • b569703 new: Remove 'help wanted' label from closed issues
  • 2767589 Remove unnecessary 'checkout' steps
  • dcd4a4b Remove 'help wanted' / 'needs votes' from feature requests when their PR is merged
  • da03f2c Brand the stale comment too
  • 0130a5f Fix release notes action error
  • 8da957d Add release note

📊 Changes

14 files changed (+277 additions, -111 deletions)

View changed files

➕ .github/actions/handle-feature-requests.js (+181 -0)
➖ .github/workflows/check-release-notes.yml (+0 -16)
➕ .github/workflows/check.yml (+34 -0)
➖ .github/workflows/generate-release-notes.yml (+0 -17)
📝 .github/workflows/issues-add-triage-label.yml (+1 -1)
📝 .github/workflows/issues-close-feature-requests.yml (+3 -3)
➕ .github/workflows/issues-feature-implemented.yml (+20 -0)
➕ .github/workflows/issues-remove-help-wanted.yml (+14 -0)
➖ .github/workflows/lint.yml (+0 -18)
➕ .github/workflows/release-notes.yml (+18 -0)
➖ .github/workflows/stale.yml (+0 -20)
➖ .github/workflows/test.yml (+0 -18)
➖ .github/workflows/typecheck.yml (+0 -18)
➕ upcoming-release-notes/1001.md (+6 -0)

📄 Description

When a PR that contains the magic message “fixes/closes/resolves #” (or has had the issues manually linked in the “Development” section of the sidebar) is merged, all referenced issues will be checked. If any of them are a feature request:

  • They will have the “needs votes” and “help wanted” labels removed (if applicable)
  • The comment asking for votes will be collapsed as outdated
  • A new comment will be posted linking to the PR and saying it will be included in the next release

I also took the opportunity to make a few other changes:

  • Reorganize the lint, test, & typecheck actions into one workflow file since they run in the same cases
  • Hopefully fix the issue where the “Check release notes” action would run on release PRs
  • Remove actions/checkout from issue-only workflows to speed them up
  • Don’t add the “needs triage” label if labels are present on the new issue already; this makes it less annoying for collaborators to open issues since they will not need to remove the label
  • brand new auto-generated comments with an HTML comment that makes them easier for automations to find in the future
  • Automatically remove the “help wanted” label when an issue is closed (unless it has the “feature” label)

Fixes #997.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/1001 **Author:** [@j-f1](https://github.com/j-f1) **Created:** 5/5/2023 **Status:** ✅ Merged **Merged:** 5/6/2023 **Merged by:** [@j-f1](https://github.com/j-f1) **Base:** `master` ← **Head:** `jed/actions-maintenance` --- ### 📝 Commits (10+) - [`6a0e26e`](https://github.com/actualbudget/actual/commit/6a0e26e146cc5f7d71deadfe32bd8ea395db7536) Merge release notes actions into one - [`8a56abf`](https://github.com/actualbudget/actual/commit/8a56abf8be7167217e45d3c8797f84ab0a0afcec) Only add the `needs triage` label if there are no labels - [`9fb68b3`](https://github.com/actualbudget/actual/commit/9fb68b32e04c17fbe65a59a340e1c6291ef57bcb) Rename stale workflow to match with other issues actions - [`ad44359`](https://github.com/actualbudget/actual/commit/ad44359c0dc9dd1fc2c7b627b52371a764432563) Merge test, lint, & typecheck into one workflow - [`b569703`](https://github.com/actualbudget/actual/commit/b569703e1667ed60c3b26110c2ca4d3b50fc7fff) new: Remove 'help wanted' label from closed issues - [`2767589`](https://github.com/actualbudget/actual/commit/2767589b5e959630cca899dd9d0d7390712fe612) Remove unnecessary 'checkout' steps - [`dcd4a4b`](https://github.com/actualbudget/actual/commit/dcd4a4bfd643f87139bde3df64e1bbb796bb6e15) Remove 'help wanted' / 'needs votes' from feature requests when their PR is merged - [`da03f2c`](https://github.com/actualbudget/actual/commit/da03f2c30c3fbd4a28ef87b420f6c1799fb1c577) Brand the stale comment too - [`0130a5f`](https://github.com/actualbudget/actual/commit/0130a5fb2713e7ac8bed488a5fa42da7811ccdfd) Fix release notes action error - [`8da957d`](https://github.com/actualbudget/actual/commit/8da957d217dbc65ab4bf4f2db0639c12b4f9f185) Add release note ### 📊 Changes **14 files changed** (+277 additions, -111 deletions) <details> <summary>View changed files</summary> ➕ `.github/actions/handle-feature-requests.js` (+181 -0) ➖ `.github/workflows/check-release-notes.yml` (+0 -16) ➕ `.github/workflows/check.yml` (+34 -0) ➖ `.github/workflows/generate-release-notes.yml` (+0 -17) 📝 `.github/workflows/issues-add-triage-label.yml` (+1 -1) 📝 `.github/workflows/issues-close-feature-requests.yml` (+3 -3) ➕ `.github/workflows/issues-feature-implemented.yml` (+20 -0) ➕ `.github/workflows/issues-remove-help-wanted.yml` (+14 -0) ➖ `.github/workflows/lint.yml` (+0 -18) ➕ `.github/workflows/release-notes.yml` (+18 -0) ➖ `.github/workflows/stale.yml` (+0 -20) ➖ `.github/workflows/test.yml` (+0 -18) ➖ `.github/workflows/typecheck.yml` (+0 -18) ➕ `upcoming-release-notes/1001.md` (+6 -0) </details> ### 📄 Description When a PR that contains the magic message “fixes/closes/resolves #<issue number>” (or has had the issues manually linked in the “Development” section of the sidebar) is merged, all referenced issues will be checked. If any of them are a feature request: - They will have the “needs votes” and “help wanted” labels removed (if applicable) - The comment asking for votes will be collapsed as outdated - A new comment will be posted linking to the PR and saying it will be included in the next release I also took the opportunity to make a few other changes: - Reorganize the lint, test, & typecheck actions into one workflow file since they run in the same cases - Hopefully fix the issue where the “Check release notes” action would run on release PRs - Remove `actions/checkout` from issue-only workflows to speed them up - Don’t add the “needs triage” label if labels are present on the new issue already; this makes it less annoying for collaborators to open issues since they will not need to remove the label - brand new auto-generated comments with an HTML comment that makes them easier for automations to find in the future - Automatically remove the “help wanted” label when an issue is closed (unless it has the “feature” label) Fixes #997. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:41:57 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#3458
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?