github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 11:42:54 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #961] [MERGED] Priorities for goals #3432

New Issue
Closed
opened 2026-02-28 20:41:32 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:41:32 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/961
Author: @shall0pass
Created: 4/27/2023
Status: ✅ Merged
Merged: 5/2/2023
Merged by: @j-f1

Base: master ← Head: priorityGoals

📝 Commits (10+)

📊 Changes

3 files changed (+196 additions, -55 deletions)

View changed files

📝 packages/loot-core/src/server/budget/goal-template.pegjs (+14 -12)
📝 packages/loot-core/src/server/budget/goaltemplates.ts (+176 -43)
➕ upcoming-release-notes/961.md (+6 -0)

📄 Description

This attempts to add priorities for goal templates and addresses most of https://github.com/actualbudget/actual/issues/959.

I couldn't find a good way to preserve both "Apply" and "Overwrite" operations, so this PR does away with the current "Apply" action behavior. Every box with a budgeted value will be overwritten if a template goal is present.

The added syntax to define priorities is as follows:
#template -- priority 0, highest priority
#template-1 --priority 1, 2nd highest priority
#template-2 --priority 2, 3rd highest priority
#template-N --priority N, as many as you'd like.

Leaving as a draft as this may not be the preferred implementation but I wanted others to be able to try it with netlify.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/961 **Author:** [@shall0pass](https://github.com/shall0pass) **Created:** 4/27/2023 **Status:** ✅ Merged **Merged:** 5/2/2023 **Merged by:** [@j-f1](https://github.com/j-f1) **Base:** `master` ← **Head:** `priorityGoals` --- ### 📝 Commits (10+) - [`45bc7c9`](https://github.com/actualbudget/actual/commit/45bc7c9773ef1faa78814c46c0048e70cd35377c) first pass for priorities, breaks compounding - [`7289e4e`](https://github.com/actualbudget/actual/commit/7289e4eefe23531e15d06d0ca9e415cde3b11991) allow partial fills - [`36906e2`](https://github.com/actualbudget/actual/commit/36906e2d5175fbf6389c98040c7b0ab692a80249) new template parser - [`56b2887`](https://github.com/actualbudget/actual/commit/56b2887d8736a5138baaf5e2ad70f8d11448439c) Merge pull request #33 from youngcw/priority_template - [`82c4b35`](https://github.com/actualbudget/actual/commit/82c4b3576874430b654569e384dcc2ae29f170eb) use youngcw peggy parser, updates - [`4a29492`](https://github.com/actualbudget/actual/commit/4a2949217d0f85570f1e1b334cbc4a4caab88644) prioritized compounding - [`82d1ed0`](https://github.com/actualbudget/actual/commit/82d1ed0345a3ce43c9db07f85b30818991cd4e54) fixup - [`7ee7762`](https://github.com/actualbudget/actual/commit/7ee7762758272a7713d3a6442fc39d4d5903e5c0) remove extra button - [`d986b95`](https://github.com/actualbudget/actual/commit/d986b95e59ae23463164bcce3cfbe6d9ad21e211) release notes - [`4a39d8d`](https://github.com/actualbudget/actual/commit/4a39d8d9837d37f4a9055df840266bec43d613e8) credit where credit is due ### 📊 Changes **3 files changed** (+196 additions, -55 deletions) <details> <summary>View changed files</summary> 📝 `packages/loot-core/src/server/budget/goal-template.pegjs` (+14 -12) 📝 `packages/loot-core/src/server/budget/goaltemplates.ts` (+176 -43) ➕ `upcoming-release-notes/961.md` (+6 -0) </details> ### 📄 Description This attempts to add priorities for goal templates and addresses most of https://github.com/actualbudget/actual/issues/959. I couldn't find a good way to preserve both "Apply" and "Overwrite" operations, so this PR does away with the current "Apply" action behavior. Every box with a budgeted value will be overwritten if a template goal is present. The added syntax to define priorities is as follows: #template -- priority 0, highest priority #template-1 --priority 1, 2nd highest priority #template-2 --priority 2, 3rd highest priority #template-N --priority N, as many as you'd like. ~~Leaving as a draft as this may not be the preferred implementation but I wanted others to be able to try it with netlify.~~ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:41:32 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#3432
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?