[PR #3391] [MERGED] Refine Menu/Select types to allow broader types for the value/name attribute #4826

New Issue

GiteaMirror · 2026-02-28T21:01:50-06:00

GiteaMirror commented

2026-02-28 21:01:50 -06:00

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/3391
Author: @jfdoming
Created: 9/8/2024
Status: ✅ Merged
Merged: 9/8/2024
Merged by: @jfdoming

Base: master ← Head: jfdoming/refine-menu-types

📝 Commits (2)

9e36ff2 Refine Menu/Select types to allow arbitrary value types
1f6e0bb Add release notes

📊 Changes

5 files changed (+93 additions, -80 deletions)

View changed files

📝 packages/desktop-client/src/components/common/Menu.tsx (+34 -18)
📝 packages/desktop-client/src/components/common/Select.tsx (+7 -5)
📝 packages/desktop-client/src/components/reports/ReportSidebar.tsx (+5 -6)
📝 packages/desktop-client/src/components/reports/SaveReportMenu.tsx (+41 -51)
➕ upcoming-release-notes/3391.md (+6 -0)

📄 Description

This is useful in general but in particular for migrating some components such as RecurringSchedulePicker to TypeScript—these components use non-string types for values (e.g. number).

The non-Select non-Menu component changes are to switch those components to use the correct types instead of inferring from the props of Select/Menu. Using props doesn't play well with generics.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/3391 **Author:** [@jfdoming](https://github.com/jfdoming) **Created:** 9/8/2024 **Status:** ✅ Merged **Merged:** 9/8/2024 **Merged by:** [@jfdoming](https://github.com/jfdoming) **Base:** `master` ← **Head:** `jfdoming/refine-menu-types` --- ### 📝 Commits (2) - [`9e36ff2`](https://github.com/actualbudget/actual/commit/9e36ff22644c9609dab7431ecb44f2b528460a3a) Refine `Menu`/`Select` types to allow arbitrary value types - [`1f6e0bb`](https://github.com/actualbudget/actual/commit/1f6e0bb2918b666b078fc48046875b6b159fcc25) Add release notes ### 📊 Changes **5 files changed** (+93 additions, -80 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/common/Menu.tsx` (+34 -18) 📝 `packages/desktop-client/src/components/common/Select.tsx` (+7 -5) 📝 `packages/desktop-client/src/components/reports/ReportSidebar.tsx` (+5 -6) 📝 `packages/desktop-client/src/components/reports/SaveReportMenu.tsx` (+41 -51) ➕ `upcoming-release-notes/3391.md` (+6 -0) </details> ### 📄 Description This is useful in general but in particular for migrating some components such as `RecurringSchedulePicker` to TypeScript—these components use non-string types for values (e.g. `number`). The non-`Select` non-`Menu` component changes are to switch those components to use the correct types instead of inferring from the props of `Select`/`Menu`. Using props doesn't play well with generics. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-02-28 21:01:50 -06:00

GiteaMirror closed this issue

[PR #3391] [MERGED] Refine Menu/Select types to allow broader types for the value/name attribute #4826

📋 Pull Request Information

📝 Commits (2)

📊 Changes

📄 Description

[PR #3391] [MERGED] Refine `Menu`/`Select` types to allow broader types for the `value`/`name` attribute #4826