github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 07:01:45 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #4882] [MERGED] Tests for goal templates #47463

New Issue
Closed
opened 2026-04-26 09:28:15 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-26 09:28:15 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/4882
Author: @youngcw
Created: 4/24/2025
Status: ✅ Merged
Merged: 5/12/2025
Merged by: @youngcw

Base: master ← Head: youngcw/template-tests

📝 Commits (10+)

📊 Changes

4 files changed (+1111 additions, -42 deletions)

View changed files

➕ packages/loot-core/src/server/budget/categoryTemplate.test.ts (+1028 -0)
📝 packages/loot-core/src/server/budget/categoryTemplate.ts (+59 -39)
📝 packages/loot-core/src/server/budget/types/templates.d.ts (+18 -3)
➕ upcoming-release-notes/4882.md (+6 -0)

📄 Description

Tests for the template processing functions and a full chain for single categories.

Adds tests for:
each template type individually
variations of limits
misc stacked templates (throughout, not a specific section)
full chain tests
full chain with goals

Utilized Cursor IDE
resolves #1686

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/4882 **Author:** [@youngcw](https://github.com/youngcw) **Created:** 4/24/2025 **Status:** ✅ Merged **Merged:** 5/12/2025 **Merged by:** [@youngcw](https://github.com/youngcw) **Base:** `master` ← **Head:** `youngcw/template-tests` --- ### 📝 Commits (10+) - [`d2bba25`](https://github.com/actualbudget/actual/commit/d2bba25a9a248f032d70cba92392aabbf30bc551) start - [`7ec3d78`](https://github.com/actualbudget/actual/commit/7ec3d78922fdf0f6e6c9193d7d49378ba47058fd) make week tests make sense - [`801bdc9`](https://github.com/actualbudget/actual/commit/801bdc9ca70990ba3dbcc7e47f17fc09ce40e8f8) fix - [`74cdcef`](https://github.com/actualbudget/actual/commit/74cdcefca8dc949cb1f0dd0387eebb0e01f54be9) copy - [`84f1cba`](https://github.com/actualbudget/actual/commit/84f1cba65d00a8fe6010d2fb26f81cb65dce9f65) average - [`e5da31b`](https://github.com/actualbudget/actual/commit/e5da31b90706e2470c1d67695c354e970c1b18e6) no call checks - [`6b88fdb`](https://github.com/actualbudget/actual/commit/6b88fdbbfe9905f7885330335b3e59ba00534965) add rest. Still need to vet runSpend, and runBy - [`7491e12`](https://github.com/actualbudget/actual/commit/7491e12984919e8c01d19f63923f4cd4b30428e4) fix average - [`edc595f`](https://github.com/actualbudget/actual/commit/edc595f86bb77a605ecbae213b0db4e93fe54d98) tweak spend - [`55dff18`](https://github.com/actualbudget/actual/commit/55dff18ac8c0a13eab0657ebf2b2e0ef4f1ed082) updates ### 📊 Changes **4 files changed** (+1111 additions, -42 deletions) <details> <summary>View changed files</summary> ➕ `packages/loot-core/src/server/budget/categoryTemplate.test.ts` (+1028 -0) 📝 `packages/loot-core/src/server/budget/categoryTemplate.ts` (+59 -39) 📝 `packages/loot-core/src/server/budget/types/templates.d.ts` (+18 -3) ➕ `upcoming-release-notes/4882.md` (+6 -0) </details> ### 📄 Description Tests for the template processing functions and a full chain for single categories. Adds tests for: each template type individually variations of limits misc stacked templates (throughout, not a specific section) full chain tests full chain with goals Utilized Cursor IDE resolves #1686 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-26 09:28:15 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#47463
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?