github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 07:01:45 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #3572] [MERGED] Fix rules not checking "category is nothing" when reconciling #46748

New Issue
Closed
opened 2026-04-26 08:46:45 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-26 08:46:45 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/3572
Author: @davidmartos96
Created: 10/4/2024
Status: ✅ Merged
Merged: 10/9/2024
Merged by: @matt-fidd

Base: master ← Head: fix-is-nothing-category-rule

📝 Commits (4)

  • 9e6f1a3 Fix rules not checking "category is nothing" when reconciling
  • 709698c release notes
  • 9dd4342 Apply suggestions from code review
  • b357a7f Merge branch 'master' into fix-is-nothing-category-rule

📊 Changes

2 files changed (+9 additions, -0 deletions)

View changed files

📝 packages/loot-core/src/server/accounts/sync.ts (+3 -0)
➕ upcoming-release-notes/3572.md (+6 -0)

📄 Description

Fixes #2540

The call to runRules passes a transaction that doesn't include a category (aka undefined), so the rule checking "category is nothing" doesn't work.
My solution is to provide a category or null in both normalizeBankSyncTransactions and normalizeTransactions

This is my first dig into the source of the project, but hopefully this solution or similar is valid.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/3572 **Author:** [@davidmartos96](https://github.com/davidmartos96) **Created:** 10/4/2024 **Status:** ✅ Merged **Merged:** 10/9/2024 **Merged by:** [@matt-fidd](https://github.com/matt-fidd) **Base:** `master` ← **Head:** `fix-is-nothing-category-rule` --- ### 📝 Commits (4) - [`9e6f1a3`](https://github.com/actualbudget/actual/commit/9e6f1a333a909143a4cdda08aa77f7ed60e19874) Fix rules not checking "category is nothing" when reconciling - [`709698c`](https://github.com/actualbudget/actual/commit/709698c47487b10cbd7629df43d76a153c5735e9) release notes - [`9dd4342`](https://github.com/actualbudget/actual/commit/9dd43423f40656e6ad5ef328a5b7dc22e5029de5) Apply suggestions from code review - [`b357a7f`](https://github.com/actualbudget/actual/commit/b357a7f1a29160e4e955832de1c274ab437426e5) Merge branch 'master' into fix-is-nothing-category-rule ### 📊 Changes **2 files changed** (+9 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `packages/loot-core/src/server/accounts/sync.ts` (+3 -0) ➕ `upcoming-release-notes/3572.md` (+6 -0) </details> ### 📄 Description Fixes #2540 The call to `runRules` passes a transaction that doesn't include a category (aka undefined), so the rule checking "category is nothing" doesn't work. My solution is to provide a category or null in both `normalizeBankSyncTransactions` and `normalizeTransactions` This is my first dig into the source of the project, but hopefully this solution or similar is valid. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-26 08:46:45 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#46748
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?