github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-10 12:12:39 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #3045] [MERGED] Enhance Autocomplete sorting, Payees tab filter, and Schedules tab filter to ignore characters with accents / diacritics #4653

New Issue
Closed
opened 2026-02-28 20:59:09 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:59:09 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/3045
Author: @NullScope
Created: 7/12/2024
Status: ✅ Merged
Merged: 7/22/2024
Merged by: @matt-fidd

Base: master ← Head: sort-diacritics-and-filter-payees

📝 Commits (10+)

  • df86ba9 Autocomplete sort now ignores diacritics
  • f53482e Payees tab now takes into account diacritics
  • dfe435d Category Autocomplete now ignores diacritics
  • 7cdf173 Schedules filter now ignore diacritics
  • 3c4739c Added release note
  • 6fc2f9a Fixed type error
  • 7e2f9b9 Added normalisation to manage rules filter
  • c0923d1 Added normalisation to $like operator
  • 86b26e2 Added normalisation function to loot-core
  • 653ea1e Fixed type error & added normalisation to notlike

📊 Changes

13 files changed (+79 additions, -38 deletions)

View changed files

📝 packages/desktop-client/src/components/ManageRules.tsx (+4 -3)
📝 packages/desktop-client/src/components/autocomplete/Autocomplete.tsx (+4 -10)
📝 packages/desktop-client/src/components/autocomplete/CategoryAutocomplete.tsx (+21 -14)
📝 packages/desktop-client/src/components/autocomplete/PayeeAutocomplete.tsx (+7 -2)
📝 packages/desktop-client/src/components/payees/ManagePayees.jsx (+2 -1)
📝 packages/desktop-client/src/components/schedules/SchedulesTable.tsx (+3 -2)
📝 packages/loot-core/src/platform/server/sqlite/index.electron.ts (+3 -0)
📝 packages/loot-core/src/platform/server/sqlite/index.web.ts (+2 -0)
➕ packages/loot-core/src/platform/server/sqlite/normalise.ts (+9 -0)
📝 packages/loot-core/src/server/aql/compiler.test.ts (+8 -4)
📝 packages/loot-core/src/server/aql/compiler.ts (+4 -2)
➕ packages/loot-core/src/shared/normalisation.ts (+6 -0)
➕ upcoming-release-notes/3045.md (+6 -0)

📄 Description

Following the PR #2842 from @lelemm I found some other places where we can enhance the input fields for languages with accents / diacritics.

Namely, sorting from autocomplete was giving preference to strings with longer length but no accents. I also found some pages like the Payees and Schedules that were filtering but not autocompleting that were having the same issue.

EDIT: Also done the same for category groups

Here is a video of the issue with the autocomplete sorting and Payees tab filter

https://github.com/user-attachments/assets/274a6949-a5d2-4138-b68b-bac83f74afb4

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/3045 **Author:** [@NullScope](https://github.com/NullScope) **Created:** 7/12/2024 **Status:** ✅ Merged **Merged:** 7/22/2024 **Merged by:** [@matt-fidd](https://github.com/matt-fidd) **Base:** `master` ← **Head:** `sort-diacritics-and-filter-payees` --- ### 📝 Commits (10+) - [`df86ba9`](https://github.com/actualbudget/actual/commit/df86ba9c015f218397d923fd74c2dbfc2005a753) Autocomplete sort now ignores diacritics - [`f53482e`](https://github.com/actualbudget/actual/commit/f53482e62fd8bff74d8c7b863ecfe9a052d2b973) Payees tab now takes into account diacritics - [`dfe435d`](https://github.com/actualbudget/actual/commit/dfe435d5092c2c68add5eecbdaaad88fd19355af) Category Autocomplete now ignores diacritics - [`7cdf173`](https://github.com/actualbudget/actual/commit/7cdf1738964189f4773878fbccc27bc198d6f660) Schedules filter now ignore diacritics - [`3c4739c`](https://github.com/actualbudget/actual/commit/3c4739c5921c8f159bde638e1cac44d41c2bfb47) Added release note - [`6fc2f9a`](https://github.com/actualbudget/actual/commit/6fc2f9ae3155dc0780b05841100629a43b595b80) Fixed type error - [`7e2f9b9`](https://github.com/actualbudget/actual/commit/7e2f9b9ae4e484e0aea67a3efba4998783ff672e) Added normalisation to manage rules filter - [`c0923d1`](https://github.com/actualbudget/actual/commit/c0923d150e9d49856807003e970009f0f5c7f2fd) Added normalisation to $like operator - [`86b26e2`](https://github.com/actualbudget/actual/commit/86b26e2f6fd88a5dd6b9cf350975d1447480c807) Added normalisation function to loot-core - [`653ea1e`](https://github.com/actualbudget/actual/commit/653ea1e348534362abee3352aab78123bc6a699c) Fixed type error & added normalisation to notlike ### 📊 Changes **13 files changed** (+79 additions, -38 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/ManageRules.tsx` (+4 -3) 📝 `packages/desktop-client/src/components/autocomplete/Autocomplete.tsx` (+4 -10) 📝 `packages/desktop-client/src/components/autocomplete/CategoryAutocomplete.tsx` (+21 -14) 📝 `packages/desktop-client/src/components/autocomplete/PayeeAutocomplete.tsx` (+7 -2) 📝 `packages/desktop-client/src/components/payees/ManagePayees.jsx` (+2 -1) 📝 `packages/desktop-client/src/components/schedules/SchedulesTable.tsx` (+3 -2) 📝 `packages/loot-core/src/platform/server/sqlite/index.electron.ts` (+3 -0) 📝 `packages/loot-core/src/platform/server/sqlite/index.web.ts` (+2 -0) ➕ `packages/loot-core/src/platform/server/sqlite/normalise.ts` (+9 -0) 📝 `packages/loot-core/src/server/aql/compiler.test.ts` (+8 -4) 📝 `packages/loot-core/src/server/aql/compiler.ts` (+4 -2) ➕ `packages/loot-core/src/shared/normalisation.ts` (+6 -0) ➕ `upcoming-release-notes/3045.md` (+6 -0) </details> ### 📄 Description Following the PR #2842 from @lelemm I found some other places where we can enhance the input fields for languages with accents / diacritics. Namely, sorting from autocomplete was giving preference to strings with longer length but no accents. I also found some pages like the Payees and Schedules that were filtering but not autocompleting that were having the same issue. EDIT: Also done the same for category groups Here is a video of the issue with the autocomplete sorting and Payees tab filter https://github.com/user-attachments/assets/274a6949-a5d2-4138-b68b-bac83f74afb4 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:59:09 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#4653
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?