[PR #2511] [MERGED] [Maintenance] Extract menus to separate files (changes split from #2472) #46162

Closed
opened 2026-04-26 08:15:14 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/2511
Author: @joel-jeremy
Created: 3/27/2024
Status: Merged
Merged: 4/2/2024
Merged by: @joel-jeremy

Base: masterHead: split-from-2472


📝 Commits (4)

📊 Changes

15 files changed (+633 additions, -433 deletions)

View changed files

📝 packages/desktop-client/src/components/budget/index.tsx (+3 -3)
packages/desktop-client/src/components/budget/report/BalanceMenu.tsx (+44 -0)
📝 packages/desktop-client/src/components/budget/report/BalanceTooltip.tsx (+7 -18)
packages/desktop-client/src/components/budget/rollover/BalanceMenu.tsx (+67 -0)
📝 packages/desktop-client/src/components/budget/rollover/BalanceTooltip.tsx (+18 -39)
📝 packages/desktop-client/src/components/budget/rollover/CoverTooltip.tsx (+32 -17)
📝 packages/desktop-client/src/components/budget/rollover/RolloverContext.tsx (+3 -3)
📝 packages/desktop-client/src/components/budget/rollover/TransferTooltip.tsx (+53 -57)
📝 packages/desktop-client/src/components/budget/rollover/budgetsummary/ToBudget.tsx (+50 -112)
packages/desktop-client/src/components/budget/rollover/budgetsummary/ToBudgetAmount.tsx (+92 -0)
packages/desktop-client/src/components/budget/rollover/budgetsummary/ToBudgetMenu.tsx (+53 -0)
📝 packages/desktop-client/src/components/common/Menu.tsx (+19 -34)
packages/desktop-client/src/components/mobile/MobileForms.jsx (+0 -150)
packages/desktop-client/src/components/mobile/MobileForms.tsx (+186 -0)
upcoming-release-notes/2511.md (+6 -0)

📄 Description

Split some changes from https://github.com/actualbudget/actual/pull/2472 for easier review


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/2511 **Author:** [@joel-jeremy](https://github.com/joel-jeremy) **Created:** 3/27/2024 **Status:** ✅ Merged **Merged:** 4/2/2024 **Merged by:** [@joel-jeremy](https://github.com/joel-jeremy) **Base:** `master` ← **Head:** `split-from-2472` --- ### 📝 Commits (4) - [`9b49f23`](https://github.com/actualbudget/actual/commit/9b49f235314b34fa1bcf70d1318119bcb76f8169) Extract menus to separate files (change split from #2472) - [`7b5c253`](https://github.com/actualbudget/actual/commit/7b5c253b2d197b11ac5c855627f347be525f116c) Release notes - [`0d55e80`](https://github.com/actualbudget/actual/commit/0d55e80b3def57fb1d5402e074e702830a04af33) Fix lint error - [`7987f5c`](https://github.com/actualbudget/actual/commit/7987f5c38339a2c8b70906556c05f2685cbed560) Code review feedback ### 📊 Changes **15 files changed** (+633 additions, -433 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/budget/index.tsx` (+3 -3) ➕ `packages/desktop-client/src/components/budget/report/BalanceMenu.tsx` (+44 -0) 📝 `packages/desktop-client/src/components/budget/report/BalanceTooltip.tsx` (+7 -18) ➕ `packages/desktop-client/src/components/budget/rollover/BalanceMenu.tsx` (+67 -0) 📝 `packages/desktop-client/src/components/budget/rollover/BalanceTooltip.tsx` (+18 -39) 📝 `packages/desktop-client/src/components/budget/rollover/CoverTooltip.tsx` (+32 -17) 📝 `packages/desktop-client/src/components/budget/rollover/RolloverContext.tsx` (+3 -3) 📝 `packages/desktop-client/src/components/budget/rollover/TransferTooltip.tsx` (+53 -57) 📝 `packages/desktop-client/src/components/budget/rollover/budgetsummary/ToBudget.tsx` (+50 -112) ➕ `packages/desktop-client/src/components/budget/rollover/budgetsummary/ToBudgetAmount.tsx` (+92 -0) ➕ `packages/desktop-client/src/components/budget/rollover/budgetsummary/ToBudgetMenu.tsx` (+53 -0) 📝 `packages/desktop-client/src/components/common/Menu.tsx` (+19 -34) ➖ `packages/desktop-client/src/components/mobile/MobileForms.jsx` (+0 -150) ➕ `packages/desktop-client/src/components/mobile/MobileForms.tsx` (+186 -0) ➕ `upcoming-release-notes/2511.md` (+6 -0) </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes --> Split some changes from https://github.com/actualbudget/actual/pull/2472 for easier review --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-26 08:15:14 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#46162