github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 07:01:45 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #2312] [MERGED] [Enhancement] Theme: Midnight #46064

New Issue
Closed
opened 2026-04-26 08:09:48 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-26 08:09:48 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/2312
Author: @shall0pass
Created: 2/1/2024
Status: ✅ Merged
Merged: 2/16/2024
Merged by: @shall0pass

Base: master ← Head: midnight

📝 Commits (10+)

📊 Changes

6 files changed (+207 additions, -3 deletions)

View changed files

📝 packages/desktop-client/src/components/ThemeSelector.tsx (+1 -0)
📝 packages/desktop-client/src/style/theme.tsx (+3 -1)
➕ packages/desktop-client/src/style/themes/midnight.ts (+191 -0)
📝 packages/loot-core/src/server/main.ts (+5 -1)
📝 packages/loot-core/src/types/prefs.d.ts (+1 -1)
➕ upcoming-release-notes/2312.md (+6 -0)

📄 Description

There are a few places I wanted a slightly different shade, but two different components are using the same variable.

Feel free to push PR's to this branch, especially if you know exactly what you want changed.

There's also a bug I wasn't able to sort out. The theme choice doesn't seem to be saved as a global pref. I'm not sure what's overriding it. At one point I wrote out to the console every time the useTheme() function was called. Most pages (reports, payees, schedules, etc) called the function once, but the settings page calls it 5 times. The first two calls it gets the correct theme, but by the time the 3rd call is made the theme has been changed to 'light' and that's the end result.

I left a few comments in place to remind me of what changes what. Unfortunately, I started commenting late in the process so there is a lot missing. They can be removed when everyone's happy with it.

Preview images
image
image
image
image
image

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/2312 **Author:** [@shall0pass](https://github.com/shall0pass) **Created:** 2/1/2024 **Status:** ✅ Merged **Merged:** 2/16/2024 **Merged by:** [@shall0pass](https://github.com/shall0pass) **Base:** `master` ← **Head:** `midnight` --- ### 📝 Commits (10+) - [`83a657a`](https://github.com/actualbudget/actual/commit/83a657aa6e94d3e7c4102f7c4b990f6abcaee317) midnight updates - [`00a17f8`](https://github.com/actualbudget/actual/commit/00a17f8845e2b34333c21e98648242c4d6951456) Merge branch 'actualbudget:master' into midnight - [`fec1ffc`](https://github.com/actualbudget/actual/commit/fec1ffc3d8edfcf8fc61e22c022ee87d3b3e71da) updates - [`f9a2204`](https://github.com/actualbudget/actual/commit/f9a2204d385c4f680df219c570b8a3d986cbeaaf) updates - [`85c75bc`](https://github.com/actualbudget/actual/commit/85c75bc1d4f7e848bd1c666f2bdc52da561aad78) background one shade darker - [`c7704c1`](https://github.com/actualbudget/actual/commit/c7704c155db2b9a187f0720ca890dc43fe8be962) change highlights to match other accents - [`7746572`](https://github.com/actualbudget/actual/commit/774657207b0a83da2880fe03597bb4ac92f6f61e) release note - [`37a4df2`](https://github.com/actualbudget/actual/commit/37a4df24c5dd6902f5a1eb33ff229960b66ae28c) link color - [`9f2ccf9`](https://github.com/actualbudget/actual/commit/9f2ccf933cdf7a8bd33a31cf73400eb66718a8f7) variable spelling - [`867c1d4`](https://github.com/actualbudget/actual/commit/867c1d4b482e0d82dd63addd45b22ec6753a7492) Upcoming pill color ### 📊 Changes **6 files changed** (+207 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/ThemeSelector.tsx` (+1 -0) 📝 `packages/desktop-client/src/style/theme.tsx` (+3 -1) ➕ `packages/desktop-client/src/style/themes/midnight.ts` (+191 -0) 📝 `packages/loot-core/src/server/main.ts` (+5 -1) 📝 `packages/loot-core/src/types/prefs.d.ts` (+1 -1) ➕ `upcoming-release-notes/2312.md` (+6 -0) </details> ### 📄 Description There are a few places I wanted a slightly different shade, but two different components are using the same variable. Feel free to push PR's to this branch, especially if you know exactly what you want changed. There's also a bug I wasn't able to sort out. The theme choice doesn't seem to be saved as a global pref. I'm not sure what's overriding it. At one point I wrote out to the console every time the useTheme() function was called. Most pages (reports, payees, schedules, etc) called the function once, but the settings page calls it 5 times. The first two calls it gets the correct theme, but by the time the 3rd call is made the theme has been changed to 'light' and that's the end result. I left a few comments in place to remind me of what changes what. Unfortunately, I started commenting late in the process so there is a lot missing. They can be removed when everyone's happy with it. Preview images ![image](https://github.com/actualbudget/actual/assets/20625555/0e1381bd-9ccc-4429-a213-10a013347836) ![image](https://github.com/actualbudget/actual/assets/20625555/5a11ab15-cec5-42d8-9e62-f2c31ce5a5b2) ![image](https://github.com/actualbudget/actual/assets/20625555/19b3fe7a-f80c-4181-8875-72a4170791b4) ![image](https://github.com/actualbudget/actual/assets/20625555/4c22dcdf-97e1-44eb-9b0e-82086415b892) ![image](https://github.com/actualbudget/actual/assets/20625555/0fff11b3-05a4-4994-b5fe-93be4e781138) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-26 08:09:48 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#46064
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?