github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 11:42:54 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #2862] [MERGED] FIX: For Report Budget, the income categories are negative when using 'Set budgets to 3 month average' #4556

New Issue
Closed
opened 2026-02-28 20:57:35 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:57:35 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/2862
Author: @lelemm
Created: 6/10/2024
Status: ✅ Merged
Merged: 6/12/2024
Merged by: @youngcw

Base: master ← Head: ReportAvgFix

📝 Commits (9)

  • ecc57bc FIX: For Report Budget, the income categories are negative when using 'Set budgets to 3 month average'. This fix solves this issue
  • 2b0b095 added 2862.md
  • 4cffce9 Ajustments for category menu not closing properly and fix to negative values for income category copy budget
  • 6bca3ff fix lint
  • d6defcd changed variable name without changing references after lint ajust
  • 0792873 retrigger checks
  • d8a74a4 Merge branch 'actualbudget:master' into ReportAvgFix
  • 161c7db Merge branch 'master' into ReportAvgFix
  • 094bd9a smaller 2862.md

📊 Changes

3 files changed (+28 additions, -4 deletions)

View changed files

📝 packages/desktop-client/src/components/budget/report/ReportComponents.tsx (+3 -0)
📝 packages/loot-core/src/server/budget/actions.ts (+19 -4)
➕ upcoming-release-notes/2862.md (+6 -0)

📄 Description

I've been using Report Budget instead of Rollover Budget and it works nice. Now, I'm starting to use 'Set budgets to 3 month average' and I noticed that for Report Budget you can budget income (which is nice), but when you click 'Set budgets to 3 month average', this inverts the value of the average for all categories. I changed it to not invert for income categories.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/2862 **Author:** [@lelemm](https://github.com/lelemm) **Created:** 6/10/2024 **Status:** ✅ Merged **Merged:** 6/12/2024 **Merged by:** [@youngcw](https://github.com/youngcw) **Base:** `master` ← **Head:** `ReportAvgFix` --- ### 📝 Commits (9) - [`ecc57bc`](https://github.com/actualbudget/actual/commit/ecc57bc5ae7150ab84a6595c995dab7448c0010d) FIX: For Report Budget, the income categories are negative when using 'Set budgets to 3 month average'. This fix solves this issue - [`2b0b095`](https://github.com/actualbudget/actual/commit/2b0b095a02b980ff3d449d9a17de2fcc349b24e3) added 2862.md - [`4cffce9`](https://github.com/actualbudget/actual/commit/4cffce95ba73a0e813b18ec68ceac8d9bdd2dc49) Ajustments for category menu not closing properly and fix to negative values for income category copy budget - [`6bca3ff`](https://github.com/actualbudget/actual/commit/6bca3ff0c338729c06f5021808789022e86a5efd) fix lint - [`d6defcd`](https://github.com/actualbudget/actual/commit/d6defcdb685b902fdbec790b5cc833b804d9ed52) changed variable name without changing references after lint ajust - [`0792873`](https://github.com/actualbudget/actual/commit/079287378e859982bbf1e723af4119508c20cfe5) retrigger checks - [`d8a74a4`](https://github.com/actualbudget/actual/commit/d8a74a4d61899b385c1800aab824234f47d7b7cd) Merge branch 'actualbudget:master' into ReportAvgFix - [`161c7db`](https://github.com/actualbudget/actual/commit/161c7db6e8a8bcd36ef63a5985dcfe50468d5090) Merge branch 'master' into ReportAvgFix - [`094bd9a`](https://github.com/actualbudget/actual/commit/094bd9a5db7cbddcacc67a124cfb81c80ecdc264) smaller 2862.md ### 📊 Changes **3 files changed** (+28 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/budget/report/ReportComponents.tsx` (+3 -0) 📝 `packages/loot-core/src/server/budget/actions.ts` (+19 -4) ➕ `upcoming-release-notes/2862.md` (+6 -0) </details> ### 📄 Description I've been using Report Budget instead of Rollover Budget and it works nice. Now, I'm starting to use 'Set budgets to 3 month average' and I noticed that for Report Budget you can budget income (which is nice), but when you click 'Set budgets to 3 month average', this inverts the value of the average for all categories. I changed it to not invert for income categories. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:57:35 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#4556
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?