[PR #4556] [MERGED] ♻️ (components) moving select component to component library #19813

Closed
opened 2026-04-14 21:18:13 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/4556
Author: @MatissJanis
Created: 3/6/2025
Status: Merged
Merged: 3/7/2025
Merged by: @MatissJanis

Base: masterHead: matiss/move-select


📝 Commits (2)

  • 2915543 ♻️ (components) moving select component to component library
  • f6de0eb Merge remote-tracking branch 'org/master' into matiss/move-select

📊 Changes

23 files changed (+60 additions, -45 deletions)

View changed files

📝 packages/component-library/package.json (+1 -0)
📝 packages/component-library/src/Select.tsx (+5 -6)
📝 packages/desktop-client/src/components/banksync/FieldMapping.tsx (+4 -4)
📝 packages/desktop-client/src/components/filters/FiltersMenu.jsx (+2 -2)
📝 packages/desktop-client/src/components/manager/subscribe/Login.tsx (+3 -3)
📝 packages/desktop-client/src/components/manager/subscribe/OpenIdForm.tsx (+2 -2)
📝 packages/desktop-client/src/components/modals/EditAccess.tsx (+2 -2)
📝 packages/desktop-client/src/components/modals/EditRuleModal.jsx (+12 -4)
📝 packages/desktop-client/src/components/modals/EditUser.tsx (+2 -2)
📝 packages/desktop-client/src/components/modals/ImportTransactionsModal/DateFormatSelect.tsx (+1 -1)
📝 packages/desktop-client/src/components/modals/ImportTransactionsModal/ImportTransactionsModal.jsx (+2 -2)
📝 packages/desktop-client/src/components/modals/ImportTransactionsModal/SelectField.tsx (+1 -1)
📝 packages/desktop-client/src/components/modals/TransferOwnership.tsx (+2 -2)
📝 packages/desktop-client/src/components/reports/Header.tsx (+1 -1)
📝 packages/desktop-client/src/components/reports/ReportSidebar.tsx (+2 -2)
📝 packages/desktop-client/src/components/reports/reports/Spending.tsx (+1 -1)
📝 packages/desktop-client/src/components/schedules/CustomUpcomingLength.tsx (+2 -1)
📝 packages/desktop-client/src/components/schedules/UpcomingLength.tsx (+1 -1)
📝 packages/desktop-client/src/components/select/RecurringSchedulePicker.tsx (+3 -3)
📝 packages/desktop-client/src/components/settings/Format.tsx (+2 -2)

...and 3 more files

📄 Description

No description provided


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/4556 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 3/6/2025 **Status:** ✅ Merged **Merged:** 3/7/2025 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `matiss/move-select` --- ### 📝 Commits (2) - [`2915543`](https://github.com/actualbudget/actual/commit/29155431ef0e13b053f0ebe4c1736553b38286e7) :recycle: (components) moving select component to component library - [`f6de0eb`](https://github.com/actualbudget/actual/commit/f6de0ebdfe3c4c74199c84791a8854b59b3418d6) Merge remote-tracking branch 'org/master' into matiss/move-select ### 📊 Changes **23 files changed** (+60 additions, -45 deletions) <details> <summary>View changed files</summary> 📝 `packages/component-library/package.json` (+1 -0) 📝 `packages/component-library/src/Select.tsx` (+5 -6) 📝 `packages/desktop-client/src/components/banksync/FieldMapping.tsx` (+4 -4) 📝 `packages/desktop-client/src/components/filters/FiltersMenu.jsx` (+2 -2) 📝 `packages/desktop-client/src/components/manager/subscribe/Login.tsx` (+3 -3) 📝 `packages/desktop-client/src/components/manager/subscribe/OpenIdForm.tsx` (+2 -2) 📝 `packages/desktop-client/src/components/modals/EditAccess.tsx` (+2 -2) 📝 `packages/desktop-client/src/components/modals/EditRuleModal.jsx` (+12 -4) 📝 `packages/desktop-client/src/components/modals/EditUser.tsx` (+2 -2) 📝 `packages/desktop-client/src/components/modals/ImportTransactionsModal/DateFormatSelect.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/modals/ImportTransactionsModal/ImportTransactionsModal.jsx` (+2 -2) 📝 `packages/desktop-client/src/components/modals/ImportTransactionsModal/SelectField.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/modals/TransferOwnership.tsx` (+2 -2) 📝 `packages/desktop-client/src/components/reports/Header.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/reports/ReportSidebar.tsx` (+2 -2) 📝 `packages/desktop-client/src/components/reports/reports/Spending.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/schedules/CustomUpcomingLength.tsx` (+2 -1) 📝 `packages/desktop-client/src/components/schedules/UpcomingLength.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/select/RecurringSchedulePicker.tsx` (+3 -3) 📝 `packages/desktop-client/src/components/settings/Format.tsx` (+2 -2) _...and 3 more files_ </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-14 21:18:13 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#19813