github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 19:52:56 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #2803] [MERGED] Revert #2643 #4518

New Issue
Closed
opened 2026-02-28 20:56:58 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:56:58 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/2803
Author: @youngcw
Created: 5/28/2024
Status: ✅ Merged
Merged: 5/28/2024
Merged by: @youngcw

Base: master ← Head: youngcw/revert-filter-change

📝 Commits (3)

  • 494bc65 Revert "Fix amount filter to include both incoming and outgoing amounts (#2643)"
  • 8cb4d73 leave in old release note
  • 292687f note

📊 Changes

3 files changed (+20 additions, -63 deletions)

View changed files

📝 packages/loot-core/src/server/accounts/transaction-rules.test.ts (+3 -49)
📝 packages/loot-core/src/server/accounts/transaction-rules.ts (+11 -14)
➕ upcoming-release-notes/2803.md (+6 -0)

📄 Description

#2643 is a nice change, but there are multiple things that use the amount filter, like schedules, that would need changed to match the update. We could return to this after the release if desired and have time to fix the internal amount filter uses.

Also, maybe instead of changing how the filter works we would instead use the amountInput component when creating the filter to be more clear what the amount is. That way the filter uses don't have to be changed to match then new filter.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/2803 **Author:** [@youngcw](https://github.com/youngcw) **Created:** 5/28/2024 **Status:** ✅ Merged **Merged:** 5/28/2024 **Merged by:** [@youngcw](https://github.com/youngcw) **Base:** `master` ← **Head:** `youngcw/revert-filter-change` --- ### 📝 Commits (3) - [`494bc65`](https://github.com/actualbudget/actual/commit/494bc65f857da987962c058475b07c0ecd15f3e5) Revert "Fix amount filter to include both incoming and outgoing amounts (#2643)" - [`8cb4d73`](https://github.com/actualbudget/actual/commit/8cb4d73c7b2394ed9d1177c3547e91cb98bcaee4) leave in old release note - [`292687f`](https://github.com/actualbudget/actual/commit/292687fdf865246db0efeea8b4a0ffd36c8003f5) note ### 📊 Changes **3 files changed** (+20 additions, -63 deletions) <details> <summary>View changed files</summary> 📝 `packages/loot-core/src/server/accounts/transaction-rules.test.ts` (+3 -49) 📝 `packages/loot-core/src/server/accounts/transaction-rules.ts` (+11 -14) ➕ `upcoming-release-notes/2803.md` (+6 -0) </details> ### 📄 Description #2643 is a nice change, but there are multiple things that use the amount filter, like schedules, that would need changed to match the update. We could return to this after the release if desired and have time to fix the internal amount filter uses. Also, maybe instead of changing how the filter works we would instead use the amountInput component when creating the filter to be more clear what the amount is. That way the filter uses don't have to be changed to match then new filter. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:56:58 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#4518
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?