github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 11:42:54 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #2099] [MERGED] [Goals]: fully skip budgeted categories when only applying #4116

New Issue
Closed
opened 2026-02-28 20:51:45 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:51:45 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/2099
Author: @youngcw
Created: 12/17/2023
Status: ✅ Merged
Merged: 12/18/2023
Merged by: @youngcw

Base: master ← Head: youngcw/rework-apply-templates

📝 Commits (4)

📊 Changes

2 files changed (+28 additions, -40 deletions)

View changed files

📝 packages/loot-core/src/server/budget/goaltemplates.ts (+22 -40)
➕ upcoming-release-notes/2099.md (+6 -0)

📄 Description

If someone had pre-budgeted a category and only applied the templates instead of overwrote with templates, the over budget checks wouldn't consider the amounts budgeted in those already budgeted categories, causing over budget.

This changes the process of leaving existing budgets by removing those categories from the list of templated categories, instead of saving and reapplying the previous amount.

Ive attatched a test budget that shows what was happing.
There are two templates that together budget the available funds. They both have priorities set so they shouldn't be allowed to over budget. The one category has a budgeted value.

Select "Apply Budget Templates" and see the over budget even though that shouldn't be allowed.
2023-12-17-_test-budget.zip

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/2099 **Author:** [@youngcw](https://github.com/youngcw) **Created:** 12/17/2023 **Status:** ✅ Merged **Merged:** 12/18/2023 **Merged by:** [@youngcw](https://github.com/youngcw) **Base:** `master` ← **Head:** `youngcw/rework-apply-templates` --- ### 📝 Commits (4) - [`67b1b98`](https://github.com/actualbudget/actual/commit/67b1b9893ad9d381346310f927bdadec9bfdff05) remove budgeted categories from list when only applying - [`fbe3bea`](https://github.com/actualbudget/actual/commit/fbe3bea34612b8bdfa0ea5473c219efe3678055d) cleanup - [`6427075`](https://github.com/actualbudget/actual/commit/64270753dc6b803226c6f0dfac65ec64bbc1f090) speed up the category removal - [`5e84da1`](https://github.com/actualbudget/actual/commit/5e84da100424ba32abb8167c30bf3c888e53e5ea) note ### 📊 Changes **2 files changed** (+28 additions, -40 deletions) <details> <summary>View changed files</summary> 📝 `packages/loot-core/src/server/budget/goaltemplates.ts` (+22 -40) ➕ `upcoming-release-notes/2099.md` (+6 -0) </details> ### 📄 Description If someone had pre-budgeted a category and only applied the templates instead of overwrote with templates, the over budget checks wouldn't consider the amounts budgeted in those already budgeted categories, causing over budget. This changes the process of leaving existing budgets by removing those categories from the list of templated categories, instead of saving and reapplying the previous amount. Ive attatched a test budget that shows what was happing. There are two templates that together budget the available funds. They both have priorities set so they shouldn't be allowed to over budget. The one category has a budgeted value. Select "Apply Budget Templates" and see the over budget even though that shouldn't be allowed. [2023-12-17-_test-budget.zip](https://github.com/actualbudget/actual/files/13699054/2023-12-17-_test-budget.zip) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:51:45 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#4116
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?