github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 20:15:33 -05:00
Code Issues 1.5k Packages Projects Releases 55 Wiki Activity

[PR #4567] [MERGED] Do not count hidden categories in tracking budgets + cleanup table math #35653

New Issue
Closed
opened 2026-04-20 22:36:53 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-20 22:36:53 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/4567
Author: @lelemm
Created: 3/7/2025
Status: ✅ Merged
Merged: 4/16/2025
Merged by: @lelemm

Base: master ← Head: budget-nohidden-alt-version

📝 Commits (10+)

📊 Changes

5 files changed (+682 additions, -198 deletions)

View changed files

📝 packages/loot-core/src/server/budget/base.test.ts (+273 -0)
📝 packages/loot-core/src/server/budget/base.ts (+26 -189)
📝 packages/loot-core/src/server/budget/envelope.ts (+177 -0)
📝 packages/loot-core/src/server/budget/report.ts (+200 -9)
➕ upcoming-release-notes/4567.md (+6 -0)

📄 Description

This changes the budget table calculations to exclude hidden categories from totals. To test, hide and unhide categories and groups and compare the group and budget totals.

This also changes the summation for balance and spending to include all amounts that month regardless of a category balance being carried forward. The balance will still carry to the next month for now.

fixes #4116
resolves #2400

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/4567 **Author:** [@lelemm](https://github.com/lelemm) **Created:** 3/7/2025 **Status:** ✅ Merged **Merged:** 4/16/2025 **Merged by:** [@lelemm](https://github.com/lelemm) **Base:** `master` ← **Head:** `budget-nohidden-alt-version` --- ### 📝 Commits (10+) - [`05ebd2b`](https://github.com/actualbudget/actual/commit/05ebd2bb96d484a41b17c734df1e25f169894007) Alternative solution - [`18386c5`](https://github.com/actualbudget/actual/commit/18386c51a2301f5c6c1545f68f5c1134d7beb30a) tests - [`3198e19`](https://github.com/actualbudget/actual/commit/3198e1979ccaf39bc0efb6076cebc8550fe134d2) a bit better, but now categories can be weird - [`eb27237`](https://github.com/actualbudget/actual/commit/eb27237231db0caf208a2b664d56d097e6b6db9b) working, I think - [`09de42b`](https://github.com/actualbudget/actual/commit/09de42bc9aa2086103328b71499fd2c3a9535175) almost there - [`d0d6126`](https://github.com/actualbudget/actual/commit/d0d6126f8144fbd192852b8125529ed851bcfb50) I was making it harder than it needed to be - [`808b9c9`](https://github.com/actualbudget/actual/commit/808b9c9bd34a74c2461a9fa234463ad7b403e7f3) Update VRT - [`f893e45`](https://github.com/actualbudget/actual/commit/f893e45fce9e430549e52afe8104e4bc6686e2fa) note - [`92ba743`](https://github.com/actualbudget/actual/commit/92ba743ad8925ef6b247e9794622de7ca042872f) note - [`3c1cd66`](https://github.com/actualbudget/actual/commit/3c1cd66ae0a5fa63fda36112aab31a82a2e9483d) Separating logic from envelope and report to keep envelope as it was ### 📊 Changes **5 files changed** (+682 additions, -198 deletions) <details> <summary>View changed files</summary> 📝 `packages/loot-core/src/server/budget/base.test.ts` (+273 -0) 📝 `packages/loot-core/src/server/budget/base.ts` (+26 -189) 📝 `packages/loot-core/src/server/budget/envelope.ts` (+177 -0) 📝 `packages/loot-core/src/server/budget/report.ts` (+200 -9) ➕ `upcoming-release-notes/4567.md` (+6 -0) </details> ### 📄 Description This changes the budget table calculations to exclude hidden categories from totals. To test, hide and unhide categories and groups and compare the group and budget totals. This also changes the summation for balance and spending to include all amounts that month regardless of a category balance being carried forward. The balance will still carry to the next month for now. fixes #4116 resolves #2400 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 22:36:53 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#35653
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?