github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-10 04:02:38 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #1899] [MERGED] Add schedule end date/count field #4011

New Issue
Closed
opened 2026-02-28 20:50:15 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:50:15 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/1899
Author: @jfdoming
Created: 11/11/2023
Status: ✅ Merged
Merged: 12/14/2023
Merged by: @shall0pass

Base: master ← Head: jfdoming/schedule-end-date

📝 Commits (10+)

  • 6ac0c5e Add "end" field with date/count options
  • de8cfee Use "end" field to generate schedule
  • 8603c67 Show "end" field in recurring description
  • b8f4faa Disable weekend before/after picker when not enabled
  • 55037d5 Add release notes
  • a4ce13e Fix failing typechecks
  • 6f59f37 Add some description tests
  • 4b9bb17 PR feedback
  • 7761e99 'Features', not 'Feature'
  • abb3780 Fix goal templates infinite loop

📊 Changes

11 files changed (+391 additions, -126 deletions)

View changed files

📝 packages/desktop-client/src/components/common/Select.tsx (+3 -0)
📝 packages/desktop-client/src/components/rules/Value.tsx (+1 -1)
📝 packages/desktop-client/src/components/schedules/DiscoverSchedules.tsx (+5 -1)
📝 packages/desktop-client/src/components/schedules/EditSchedule.js (+3 -0)
📝 packages/desktop-client/src/components/select/RecurringSchedulePicker.js (+59 -10)
📝 packages/loot-core/src/server/budget/goals/goalsSchedule.ts (+44 -19)
📝 packages/loot-core/src/server/schedules/app.ts (+17 -4)
📝 packages/loot-core/src/shared/schedules.test.ts (+216 -86)
📝 packages/loot-core/src/shared/schedules.ts (+34 -5)
📝 packages/loot-core/src/types/models/schedule.d.ts (+3 -0)
➕ upcoming-release-notes/1899.md (+6 -0)

📄 Description

Resurrecting #407! This PR adds an end date/max occurrences field to the schedule creator. Closes #1568 and #241.

Screenshots

Current popup:

image

New popup:

image

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/1899 **Author:** [@jfdoming](https://github.com/jfdoming) **Created:** 11/11/2023 **Status:** ✅ Merged **Merged:** 12/14/2023 **Merged by:** [@shall0pass](https://github.com/shall0pass) **Base:** `master` ← **Head:** `jfdoming/schedule-end-date` --- ### 📝 Commits (10+) - [`6ac0c5e`](https://github.com/actualbudget/actual/commit/6ac0c5e1d89581dca81e7cedd81cb33b23d5a1da) Add "end" field with date/count options - [`de8cfee`](https://github.com/actualbudget/actual/commit/de8cfeed7f45063225d451dca3c2dfb8845874cf) Use "end" field to generate schedule - [`8603c67`](https://github.com/actualbudget/actual/commit/8603c67b932612cc2981aca256b47eb82e63745d) Show "end" field in recurring description - [`b8f4faa`](https://github.com/actualbudget/actual/commit/b8f4faaab10f6cabd022470883d4cfc59c754209) Disable weekend before/after picker when not enabled - [`55037d5`](https://github.com/actualbudget/actual/commit/55037d5eb1a584522551bc7164abefda334d85ae) Add release notes - [`a4ce13e`](https://github.com/actualbudget/actual/commit/a4ce13ec1b04c585afe8f74195f13b21351fd8a4) Fix failing typechecks - [`6f59f37`](https://github.com/actualbudget/actual/commit/6f59f37dc503ac560b041da9360e990dabc7feb8) Add some description tests - [`4b9bb17`](https://github.com/actualbudget/actual/commit/4b9bb175341fca891d59bc4544edb26bf0b61c10) PR feedback - [`7761e99`](https://github.com/actualbudget/actual/commit/7761e991ffafde9797c5b2890da1e961e406e8b8) 'Features', not 'Feature' - [`abb3780`](https://github.com/actualbudget/actual/commit/abb37809cf5f2074efde6ecdc4d00f7a039cd415) Fix goal templates infinite loop ### 📊 Changes **11 files changed** (+391 additions, -126 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/common/Select.tsx` (+3 -0) 📝 `packages/desktop-client/src/components/rules/Value.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/schedules/DiscoverSchedules.tsx` (+5 -1) 📝 `packages/desktop-client/src/components/schedules/EditSchedule.js` (+3 -0) 📝 `packages/desktop-client/src/components/select/RecurringSchedulePicker.js` (+59 -10) 📝 `packages/loot-core/src/server/budget/goals/goalsSchedule.ts` (+44 -19) 📝 `packages/loot-core/src/server/schedules/app.ts` (+17 -4) 📝 `packages/loot-core/src/shared/schedules.test.ts` (+216 -86) 📝 `packages/loot-core/src/shared/schedules.ts` (+34 -5) 📝 `packages/loot-core/src/types/models/schedule.d.ts` (+3 -0) ➕ `upcoming-release-notes/1899.md` (+6 -0) </details> ### 📄 Description Resurrecting #407! This PR adds an end date/max occurrences field to the schedule creator. Closes #1568 and #241. <h3>Screenshots</h3> <h4>Current popup:</h4> <img width="410" alt="image" src="https://github.com/actualbudget/actual/assets/9922514/c0ab9c96-a791-4085-a0bb-e5599a47b9fc"> <h4>New popup:</h4> <img width="409" alt="image" src="https://github.com/actualbudget/actual/assets/9922514/81d1dcec-ec97-4481-8555-46e5a77176bc"> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:50:15 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#4011
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?