github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 07:01:45 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #2544] [MERGED] Change default theme from light to the system's default theme #38790

New Issue
Closed
opened 2026-04-23 11:47:43 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-23 11:47:43 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/2544
Author: @adam-rozen
Created: 4/3/2024
Status: ✅ Merged
Merged: 4/16/2024
Merged by: @youngcw

Base: master ← Head: default-theme

📝 Commits (5)

  • 4714c52 Change Actual default theme to System Default
  • 7940bcb Add release notes
  • e804b8e Update release notes
  • a4a7ecf update vrt
  • 8608227 Merge branch 'master' into default-theme

📊 Changes

9 files changed (+7 additions, -1 deletions)

View changed files

📝 packages/desktop-client/e2e/accounts.test.js-snapshots/Accounts-creates-a-new-account-and-views-the-initial-balance-transaction-1-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/budget.test.js-snapshots/Budget-renders-the-summary-information-available-funds-overspent-budgeted-and-for-next-month-1-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/reports.test.js-snapshots/Reports-loads-net-worth-and-cash-flow-reports-1-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/rules.test.js-snapshots/Rules-checks-the-page-visuals-1-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/schedules.test.js-snapshots/Schedules-checks-the-page-visuals-1-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/settings.test.js-snapshots/Settings-checks-the-page-visuals-1-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/transactions.test.js-snapshots/Transactions-checks-the-page-visuals-1-chromium-linux.png (+0 -0)
📝 packages/loot-core/src/server/main.ts (+1 -1)
➕ upcoming-release-notes/2544.md (+6 -0)

📄 Description

This PR is to change the default visual theme from light to the system default.

At the moment, light theme is always default. There is already functionality built-in to Actual for using the system theme, so this change will just set the system theme be the default for Actual. Users can still override the theme manually like before, but now Actual will obey the user's set preference right away. This change only comes into play when the theme is not set.

I tried to test with the playwright module, but the test Schedules › creates a new schedule, posts the transaction and later completes it failed saying that the Target page, context, or browser has been closed and then it timed out. Might be a local issue, so submitting the PR to see if the automated build passes.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/2544 **Author:** [@adam-rozen](https://github.com/adam-rozen) **Created:** 4/3/2024 **Status:** ✅ Merged **Merged:** 4/16/2024 **Merged by:** [@youngcw](https://github.com/youngcw) **Base:** `master` ← **Head:** `default-theme` --- ### 📝 Commits (5) - [`4714c52`](https://github.com/actualbudget/actual/commit/4714c52ba9ff654138c4d3d919f0d0da7322b8aa) Change Actual default theme to System Default - [`7940bcb`](https://github.com/actualbudget/actual/commit/7940bcb7961c9fdf5155cbbcb5f33774479d25e8) Add release notes - [`e804b8e`](https://github.com/actualbudget/actual/commit/e804b8e603455b4d399bfdd4a54fbfa95df8cdde) Update release notes - [`a4a7ecf`](https://github.com/actualbudget/actual/commit/a4a7ecf14b205f3ddf827aa96e54f1a037c48612) update vrt - [`8608227`](https://github.com/actualbudget/actual/commit/8608227a5f25894739f0f903ef25d386746b9ae8) Merge branch 'master' into default-theme ### 📊 Changes **9 files changed** (+7 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/e2e/accounts.test.js-snapshots/Accounts-creates-a-new-account-and-views-the-initial-balance-transaction-1-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/budget.test.js-snapshots/Budget-renders-the-summary-information-available-funds-overspent-budgeted-and-for-next-month-1-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/reports.test.js-snapshots/Reports-loads-net-worth-and-cash-flow-reports-1-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/rules.test.js-snapshots/Rules-checks-the-page-visuals-1-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/schedules.test.js-snapshots/Schedules-checks-the-page-visuals-1-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/settings.test.js-snapshots/Settings-checks-the-page-visuals-1-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/transactions.test.js-snapshots/Transactions-checks-the-page-visuals-1-chromium-linux.png` (+0 -0) 📝 `packages/loot-core/src/server/main.ts` (+1 -1) ➕ `upcoming-release-notes/2544.md` (+6 -0) </details> ### 📄 Description This PR is to change the default visual theme from light to the system default. At the moment, light theme is always default. There is already functionality built-in to Actual for using the system theme, so this change will just set the system theme be the default for Actual. Users can still override the theme manually like before, but now Actual will obey the user's set preference right away. This change only comes into play when the theme is not set. I tried to test with the playwright module, but the test `Schedules › creates a new schedule, posts the transaction and later completes it` failed saying that the `Target page, context, or browser has been closed` and then it timed out. Might be a local issue, so submitting the PR to see if the automated build passes. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-23 11:47:43 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#38790
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?