github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 07:01:45 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #2438] [CLOSED] fix: Don't allow duplicate cat-groups in budget at renaming #38732

New Issue
Closed
opened 2026-04-23 11:45:13 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-23 11:45:13 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/2438
Author: @FlorianLang06
Created: 3/7/2024
Status: ❌ Closed

Base: master ← Head: dup-category-group-rename

📝 Commits (10+)

  • 2f79dae Fix crash when undoing a rule application (#1885)
  • 9ad7f63 Fix switching budget from rollover budget to report budget and immediately back does not work (#1933)
  • 2f2a31d 🔧 (eslint) disallow using 'var': no-var rule (#1949)
  • 0e60571 [Maintenance] Split up large payee management components file (#1950)
  • 4a7d67d [Maintenance] Refactor payee table to typescript (#1948)
  • f0feb69 Consistent button size in budget title bar + use zondicon eye icon (#1951)
  • 6b78cd8 ESLint prefer-const (#1956)
  • 9f2c11e ♻️ (typescript) refactor global-events to TS (#1942)
  • cee6bf1 ♻️ (typescript) ported gocardless auth file to TS (#1941)
  • db852c1 Lock transactions after reconcilliation (#1789)

📊 Changes

4250 files changed (+135151 additions, -529954 deletions)

View changed files

➖ .circleci/config.yml (+0 -121)
➕ .devcontainer/devcontainer.json (+14 -0)
➕ .devcontainer/docker-compose.yml (+6 -0)
➕ .editorconfig (+11 -0)
➕ .eslintignore (+27 -0)
➕ .eslintrc.js (+345 -0)
📝 .gitattributes (+19 -1)
➕ .github/FUNDING.yml (+3 -0)
➕ .github/ISSUE_TEMPLATE/bug-report.yml (+92 -0)
➕ .github/ISSUE_TEMPLATE/config.yml (+5 -0)
➕ .github/ISSUE_TEMPLATE/feature-request.yml (+47 -0)
➕ .github/PULL_REQUEST_TEMPLATE.md (+1 -0)
➕ .github/actions/check-migrations.js (+60 -0)
➕ .github/actions/handle-feature-requests.js (+184 -0)
➕ .github/actions/netlify-wait-for-build (+40 -0)
➕ .github/actions/setup/action.yml (+19 -0)
➕ .github/workflows/build.yml (+70 -0)
➕ .github/workflows/check.yml (+48 -0)
➕ .github/workflows/codeql.yml (+35 -0)
➕ .github/workflows/e2e-test.yml (+70 -0)

...and 80 more files

📄 Description

Checks:

  • UI Level check to check for checking duplicate group name (create and rename)
  • DB level check for the same (create and rename/update)

Inspired from PR #2262
Fixes: #2428

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/2438 **Author:** [@FlorianLang06](https://github.com/FlorianLang06) **Created:** 3/7/2024 **Status:** ❌ Closed **Base:** `master` ← **Head:** `dup-category-group-rename` --- ### 📝 Commits (10+) - [`2f79dae`](https://github.com/actualbudget/actual/commit/2f79dae643078e71305b24472591778ff34ed27c) Fix crash when undoing a rule application (#1885) - [`9ad7f63`](https://github.com/actualbudget/actual/commit/9ad7f637dd0e25553452720a470beb93c1ded5f7) Fix switching budget from rollover budget to report budget and immediately back does not work (#1933) - [`2f2a31d`](https://github.com/actualbudget/actual/commit/2f2a31d0bf40aef56e18c10bc4f912003a93a787) :wrench: (eslint) disallow using 'var': no-var rule (#1949) - [`0e60571`](https://github.com/actualbudget/actual/commit/0e6057150613109aee17914499353db84dd5f25f) [Maintenance] Split up large payee management components file (#1950) - [`4a7d67d`](https://github.com/actualbudget/actual/commit/4a7d67daa405ab930fe85a92ec3a4f00cb48c6e7) [Maintenance] Refactor payee table to typescript (#1948) - [`f0feb69`](https://github.com/actualbudget/actual/commit/f0feb69978112dbbd409196c7175f9a494cd4344) Consistent button size in budget title bar + use zondicon eye icon (#1951) - [`6b78cd8`](https://github.com/actualbudget/actual/commit/6b78cd843d360df9ee2aa24f6b9a3c013bf6b37d) ESLint prefer-const (#1956) - [`9f2c11e`](https://github.com/actualbudget/actual/commit/9f2c11e9da3417009c90a0803b3e1a83bbc24af5) :recycle: (typescript) refactor global-events to TS (#1942) - [`cee6bf1`](https://github.com/actualbudget/actual/commit/cee6bf122d3c01ba81bd08325301e782f444451c) :recycle: (typescript) ported gocardless auth file to TS (#1941) - [`db852c1`](https://github.com/actualbudget/actual/commit/db852c1e6f38c7f6c59d5b0fd526d64101835946) Lock transactions after reconcilliation (#1789) ### 📊 Changes **4250 files changed** (+135151 additions, -529954 deletions) <details> <summary>View changed files</summary> ➖ `.circleci/config.yml` (+0 -121) ➕ `.devcontainer/devcontainer.json` (+14 -0) ➕ `.devcontainer/docker-compose.yml` (+6 -0) ➕ `.editorconfig` (+11 -0) ➕ `.eslintignore` (+27 -0) ➕ `.eslintrc.js` (+345 -0) 📝 `.gitattributes` (+19 -1) ➕ `.github/FUNDING.yml` (+3 -0) ➕ `.github/ISSUE_TEMPLATE/bug-report.yml` (+92 -0) ➕ `.github/ISSUE_TEMPLATE/config.yml` (+5 -0) ➕ `.github/ISSUE_TEMPLATE/feature-request.yml` (+47 -0) ➕ `.github/PULL_REQUEST_TEMPLATE.md` (+1 -0) ➕ `.github/actions/check-migrations.js` (+60 -0) ➕ `.github/actions/handle-feature-requests.js` (+184 -0) ➕ `.github/actions/netlify-wait-for-build` (+40 -0) ➕ `.github/actions/setup/action.yml` (+19 -0) ➕ `.github/workflows/build.yml` (+70 -0) ➕ `.github/workflows/check.yml` (+48 -0) ➕ `.github/workflows/codeql.yml` (+35 -0) ➕ `.github/workflows/e2e-test.yml` (+70 -0) _...and 80 more files_ </details> ### 📄 Description Checks: - UI Level check to check for checking duplicate group name (create and rename) - DB level check for the same (create and rename/update) Inspired from PR #2262 Fixes: #2428 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-23 11:45:13 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#38732
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?