github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 15:12:35 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #1345] [CLOSED] Dispatch the click event after adding the change listener #3678

New Issue
Closed
opened 2026-02-28 20:45:07 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:45:07 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/1345
Author: @j-f1
Created: 7/15/2023
Status: ❌ Closed

Base: master ← Head: jed/file-upload

📝 Commits (3)

  • 663795a Dispatch the click event after adding the change listener
  • 4335686 Add release note
  • fd0fe5b Merge branch 'master' into jed/file-upload

📊 Changes

2 files changed (+14 additions, -7 deletions)

View changed files

📝 packages/desktop-client/src/browser-preload.browser.js (+8 -7)
➕ upcoming-release-notes/1345.md (+6 -0)

📄 Description

Fixes #1313 (hopefully). My guess is that in Safari, the click event triggers a synchronous modal to open rather than an asynchronous one, so sometimes the change event is triggered before the handler can be registered?

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/1345 **Author:** [@j-f1](https://github.com/j-f1) **Created:** 7/15/2023 **Status:** ❌ Closed **Base:** `master` ← **Head:** `jed/file-upload` --- ### 📝 Commits (3) - [`663795a`](https://github.com/actualbudget/actual/commit/663795ace2d92dda5a63110d463bbfae5b620304) Dispatch the click event after adding the change listener - [`4335686`](https://github.com/actualbudget/actual/commit/4335686692c155a4abcbb7450e4fab3495c1d9bc) Add release note - [`fd0fe5b`](https://github.com/actualbudget/actual/commit/fd0fe5bc73bf0d12c843a12cfce45948f6fccc67) Merge branch 'master' into jed/file-upload ### 📊 Changes **2 files changed** (+14 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/browser-preload.browser.js` (+8 -7) ➕ `upcoming-release-notes/1345.md` (+6 -0) </details> ### 📄 Description Fixes #1313 (hopefully). My guess is that in Safari, the click event triggers a synchronous modal to open rather than an asynchronous one, so sometimes the `change` event is triggered before the handler can be registered? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:45:08 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#3678
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?