github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 11:42:54 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #1269] [MERGED] Add typings to most of the Redux logic #3636

New Issue
Closed
opened 2026-02-28 20:44:32 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:44:32 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/1269
Author: @j-f1
Created: 7/3/2023
Status: ✅ Merged
Merged: 7/18/2023
Merged by: @j-f1

Base: master ← Head: jed/type-state

📝 Commits (10+)

  • 46c6070 Install @types/react-redux
  • 531fa35 Remove unused actions
  • 743b819 Remove now-unused state values
  • 785556e Remove unused debug reducer
  • 82886e4 Fix typo in SET_ALL_FILES handler
  • 4d8ff61 Set up type infrastructure for Redux
  • 7534bfa Add types to the account actions
  • a697f95 Add types to the app actions
  • 808a088 Add types to the budgets actions
  • 3e54631 Add types to the modals actions

📊 Changes

59 files changed (+794 additions, -473 deletions)

View changed files

📝 .eslintrc.js (+4 -3)
📝 packages/desktop-client/package.json (+1 -0)
📝 packages/desktop-client/src/components/Modals.js (+0 -13)
📝 packages/desktop-client/src/components/Notifications.tsx (+26 -9)
📝 packages/desktop-client/src/components/manager/ImportActual.js (+1 -1)
📝 packages/desktop-client/src/components/manager/ImportYNAB4.js (+1 -1)
📝 packages/desktop-client/src/components/manager/ImportYNAB5.js (+1 -1)
📝 packages/desktop-client/src/components/manager/Modals.js (+2 -10)
➖ packages/desktop-client/src/components/modals/ConfigureLinkedAccounts.js (+0 -166)
➕ packages/desktop-client/src/hooks/useActions.ts (+15 -0)
📝 packages/desktop-client/src/hooks/useFeatureFlag.ts (+5 -3)
📝 packages/loot-core/package.json (+1 -0)
📝 packages/loot-core/src/client/actions/account.ts (+30 -14)
📝 packages/loot-core/src/client/actions/app.ts (+13 -5)
📝 packages/loot-core/src/client/actions/backups.ts (+3 -2)
📝 packages/loot-core/src/client/actions/budgets.ts (+31 -15)
➖ packages/loot-core/src/client/actions/debug.ts (+0 -9)
📝 packages/loot-core/src/client/actions/index.ts (+0 -1)
📝 packages/loot-core/src/client/actions/modals.ts (+6 -12)
📝 packages/loot-core/src/client/actions/notifications.ts (+8 -3)

...and 39 more files

📄 Description

This will automatically flow types into useSelector and dispatch calls. Action (heh) item: port components to useActions() to get access to typed actions.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/1269 **Author:** [@j-f1](https://github.com/j-f1) **Created:** 7/3/2023 **Status:** ✅ Merged **Merged:** 7/18/2023 **Merged by:** [@j-f1](https://github.com/j-f1) **Base:** `master` ← **Head:** `jed/type-state` --- ### 📝 Commits (10+) - [`46c6070`](https://github.com/actualbudget/actual/commit/46c60709a56052a243d591dd0f079e652b3b0b86) Install @types/react-redux - [`531fa35`](https://github.com/actualbudget/actual/commit/531fa35f1705661e6798d970359928dd9c563d85) Remove unused actions - [`743b819`](https://github.com/actualbudget/actual/commit/743b81975565787f599ffc5d93013f98dc6fc9c2) Remove now-unused state values - [`785556e`](https://github.com/actualbudget/actual/commit/785556ea810baf5167e0cc830c5405b41d731c65) Remove unused debug reducer - [`82886e4`](https://github.com/actualbudget/actual/commit/82886e4227a7bc3a63161199f04315377df57fab) Fix typo in SET_ALL_FILES handler - [`4d8ff61`](https://github.com/actualbudget/actual/commit/4d8ff61bf607c79e708f23c7b62bd0b271525c11) Set up type infrastructure for Redux - [`7534bfa`](https://github.com/actualbudget/actual/commit/7534bfa8324e7ee490295885a6aa7c7e0014edb0) Add types to the account actions - [`a697f95`](https://github.com/actualbudget/actual/commit/a697f9581638be9d0947797b6d80c8b355e6195b) Add types to the app actions - [`808a088`](https://github.com/actualbudget/actual/commit/808a0881e0221cec6c5edeb209315af22f5f2a6c) Add types to the budgets actions - [`3e54631`](https://github.com/actualbudget/actual/commit/3e54631fb416110b393528372d9763985fd7c389) Add types to the modals actions ### 📊 Changes **59 files changed** (+794 additions, -473 deletions) <details> <summary>View changed files</summary> 📝 `.eslintrc.js` (+4 -3) 📝 `packages/desktop-client/package.json` (+1 -0) 📝 `packages/desktop-client/src/components/Modals.js` (+0 -13) 📝 `packages/desktop-client/src/components/Notifications.tsx` (+26 -9) 📝 `packages/desktop-client/src/components/manager/ImportActual.js` (+1 -1) 📝 `packages/desktop-client/src/components/manager/ImportYNAB4.js` (+1 -1) 📝 `packages/desktop-client/src/components/manager/ImportYNAB5.js` (+1 -1) 📝 `packages/desktop-client/src/components/manager/Modals.js` (+2 -10) ➖ `packages/desktop-client/src/components/modals/ConfigureLinkedAccounts.js` (+0 -166) ➕ `packages/desktop-client/src/hooks/useActions.ts` (+15 -0) 📝 `packages/desktop-client/src/hooks/useFeatureFlag.ts` (+5 -3) 📝 `packages/loot-core/package.json` (+1 -0) 📝 `packages/loot-core/src/client/actions/account.ts` (+30 -14) 📝 `packages/loot-core/src/client/actions/app.ts` (+13 -5) 📝 `packages/loot-core/src/client/actions/backups.ts` (+3 -2) 📝 `packages/loot-core/src/client/actions/budgets.ts` (+31 -15) ➖ `packages/loot-core/src/client/actions/debug.ts` (+0 -9) 📝 `packages/loot-core/src/client/actions/index.ts` (+0 -1) 📝 `packages/loot-core/src/client/actions/modals.ts` (+6 -12) 📝 `packages/loot-core/src/client/actions/notifications.ts` (+8 -3) _...and 39 more files_ </details> ### 📄 Description This will automatically flow types into `useSelector` and `dispatch` calls. Action (heh) item: port components to `useActions()` to get access to typed actions. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:44:32 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#3636
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?