github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-10 20:23:07 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #1117] [MERGED] Update recommended version to Node.js 18 #3528

New Issue
Closed
opened 2026-02-28 20:42:57 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:42:57 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/1117
Author: @j-f1
Created: 6/9/2023
Status: ✅ Merged
Merged: 6/10/2023
Merged by: @j-f1

Base: master ← Head: jed/node-18

📝 Commits (4)

📊 Changes

6 files changed (+17 additions, -8 deletions)

View changed files

📝 .github/actions/setup/action.yml (+1 -1)
📝 .nvmrc (+1 -1)
📝 Dockerfile (+3 -3)
📝 bin/docker-start (+2 -2)
📝 package.json (+4 -1)
➕ upcoming-release-notes/1117.md (+6 -0)

📄 Description

After #1115, new Node.js versions will be able to be used for development of the frontend. This PR changes the recommended Node.js version to 18 (the current LTS version). I have also tested with 16 and 20 and it works.

I also took the opportunity to:

  • move the build script that was at the project root to the bin/ folder
  • update the browserslist to target Electron 24 (which is the version we currently build against). This results in a slightly smaller bundle due to no longer having to transpile optional chaining.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/1117 **Author:** [@j-f1](https://github.com/j-f1) **Created:** 6/9/2023 **Status:** ✅ Merged **Merged:** 6/10/2023 **Merged by:** [@j-f1](https://github.com/j-f1) **Base:** `master` ← **Head:** `jed/node-18` --- ### 📝 Commits (4) - [`fe09450`](https://github.com/actualbudget/actual/commit/fe094502794685d5b30fb60bfc21ff23601685b2) Move docker-start to bin - [`f505ada`](https://github.com/actualbudget/actual/commit/f505adab94fa4848d6b9499eb6667ed571295db0) Update to Node.js 18 - [`856641e`](https://github.com/actualbudget/actual/commit/856641e29972378eaba698d3c20d0e928560a54d) Update browserslist to target Electron 24 - [`9c563e6`](https://github.com/actualbudget/actual/commit/9c563e6c5505f0f8c7423e8c5b4e145880cc76d6) Add release note ### 📊 Changes **6 files changed** (+17 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `.github/actions/setup/action.yml` (+1 -1) 📝 `.nvmrc` (+1 -1) 📝 `Dockerfile` (+3 -3) 📝 `bin/docker-start` (+2 -2) 📝 `package.json` (+4 -1) ➕ `upcoming-release-notes/1117.md` (+6 -0) </details> ### 📄 Description After #1115, new Node.js versions will be able to be used for development of the frontend. This PR changes the recommended Node.js version to 18 (the current LTS version). I have also tested with 16 and 20 and it works. I also took the opportunity to: - move the build script that was at the project root to the `bin/` folder - update the `browserslist` to target Electron 24 (which is the version we currently build against). This results in a slightly smaller bundle due to no longer having to transpile optional chaining. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:42:57 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#3528
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?