github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 19:52:56 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[Bug]: ofx amount parsing does not work for foreign number formats #1117

New Issue
Closed
opened 2026-02-28 19:32:34 -06:00 by GiteaMirror · 3 comments
GiteaMirror commented 2026-02-28 19:32:34 -06:00
Owner
Copy Link

Originally created by @Guekka on GitHub (May 25, 2024).

Verified issue does not already exist?

  • I have searched and found no existing issue
  • I will be providing steps how to reproduce the bug (in most cases this will also mean uploading a demo budget file)

What happened?

When importing an OFX file, amounts all appear as NaN. This is due to the code using the naive Number parser: source.

Solution

Using a different parser. I saw number-parsing recommended on SO.

Originally created by @Guekka on GitHub (May 25, 2024). ### Verified issue does not already exist? - [X] I have searched and found no existing issue - [X] I will be providing steps how to reproduce the bug (in most cases this will also mean uploading a demo budget file) ### What happened? When importing an OFX file, amounts all appear as NaN. This is due to the code using the naive `Number` parser: [source](https://github.com/actualbudget/actual/blob/master/packages/loot-core/src/server/accounts/parse-file.ts#L140). ### Solution Using a different parser. I saw [number-parsing](https://www.npmjs.com/package/number-parsing) recommended on SO.
GiteaMirror added the bug label 2026-02-28 19:32:34 -06:00
GiteaMirror commented 2026-02-28 19:32:35 -06:00
Author
Owner
Copy Link

@youngcw commented on GitHub (May 25, 2024):

Can you provide an example ofx file?

@youngcw commented on GitHub (May 25, 2024): Can you provide an example ofx file?
GiteaMirror commented 2026-02-28 19:32:35 -06:00
Author
Owner
Copy Link

@Guekka commented on GitHub (May 25, 2024):

Of course, gimme a minute. But any number such as -5,74 will cause a NaN

@Guekka commented on GitHub (May 25, 2024): Of course, gimme a minute. But any number such as `-5,74` will cause a `NaN`
GiteaMirror commented 2026-02-28 19:32:36 -06:00
Author
Owner
Copy Link

@Guekka commented on GitHub (May 25, 2024):

Here you go @youngcw
parsing-number-locale-issue.zip

@Guekka commented on GitHub (May 25, 2024): Here you go @youngcw [parsing-number-locale-issue.zip](https://github.com/actualbudget/actual/files/15444438/parsing-number-locale-issue.zip)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#1117
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?