[PR #3279] [MERGED] 🧹 optimise GoCardless bank sync to use fewer api calls #34964

Closed
opened 2026-04-20 22:01:53 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/3279
Author: @matt-fidd
Created: 8/17/2024
Status: Merged
Merged: 8/26/2024
Merged by: @matt-fidd

Base: masterHead: optimise


📝 Commits (6)

📊 Changes

2 files changed (+31 additions, -20 deletions)

View changed files

📝 packages/loot-core/src/server/accounts/sync.ts (+25 -20)
upcoming-release-notes/3279.md (+6 -0)

📄 Description

Part of actualbudget/actual-server#431
Complimentary PR to actualbudget/actual-server#436

The balance fetched from GoCardless is used to calculate the starting balance, which is only relevant when a completely blank account is synced. This change reduces the amount of API calls per sync, once the account has had a starting balance set, to 1 - maximising the new 10 requests/day rate limit coming on the 19th.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/3279 **Author:** [@matt-fidd](https://github.com/matt-fidd) **Created:** 8/17/2024 **Status:** ✅ Merged **Merged:** 8/26/2024 **Merged by:** [@matt-fidd](https://github.com/matt-fidd) **Base:** `master` ← **Head:** `optimise` --- ### 📝 Commits (6) - [`56ebb68`](https://github.com/actualbudget/actual/commit/56ebb685c29111087bf4bb552d6e0daba92e299f) optimise - [`39b1d02`](https://github.com/actualbudget/actual/commit/39b1d02b9899ce7fe063ca43c5688e11b38c1e4f) lint - [`919b5d4`](https://github.com/actualbudget/actual/commit/919b5d407de84a9b92586c479526840bfd4727a8) release note - [`12e115d`](https://github.com/actualbudget/actual/commit/12e115d9cae0bc37b7ee4dc29c15da2652a310e0) psybers feedback - [`b5ec7ce`](https://github.com/actualbudget/actual/commit/b5ec7ce3f89b7f7c77c8956ae81b339c77bed40d) Merge branch 'master' into optimise - [`03cec83`](https://github.com/actualbudget/actual/commit/03cec83cd0b798ee0887d9d3cc2f46d85523f880) Merge branch 'master' into optimise ### 📊 Changes **2 files changed** (+31 additions, -20 deletions) <details> <summary>View changed files</summary> 📝 `packages/loot-core/src/server/accounts/sync.ts` (+25 -20) ➕ `upcoming-release-notes/3279.md` (+6 -0) </details> ### 📄 Description Part of actualbudget/actual-server#431 Complimentary PR to actualbudget/actual-server#436 The balance fetched from GoCardless is used to calculate the starting balance, which is only relevant when a completely blank account is synced. This change reduces the amount of API calls per sync, once the account has had a starting balance set, to 1 - maximising the new 10 requests/day rate limit coming on the 19th. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 22:01:53 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#34964