github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 03:32:54 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #718] [MERGED] ⬆️ upgrade react-modal to v3.16.1 and remove the patch #3279

New Issue
Closed
opened 2026-02-28 20:39:14 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:39:14 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/718
Author: @MatissJanis
Created: 3/1/2023
Status: ✅ Merged
Merged: 3/5/2023
Merged by: @MatissJanis

Base: master ← Head: matiss/upgrade-react-modal

📝 Commits (3)

  • e44c098 ⬆️ upgrade react-modal to v3.16.1 and remove the patch
  • 26c59cc Remove ScopeTab
  • a109576 Remove console.log

📊 Changes

5 files changed (+13 additions, -48 deletions)

View changed files

📝 packages/desktop-client/package.json (+0 -1)
📝 packages/desktop-client/src/components/accounts/Filters.js (+3 -23)
📝 packages/loot-design/package.json (+1 -1)
➖ patches/react-modal+3.4.4.patch (+0 -13)
📝 yarn.lock (+9 -10)

📄 Description

Upgrading react-modal and removing the mockey patch.

Is the removal of the monkey-path safe?
I think so.. but I'm not 100% sure. And the git history doesn't help either. So I propose to remove it if we feel reasonably confident that things still work as expected. And if we notice issues after releasing: we can always roll back the change. However: at that point we will actually have some more context on the patch. Thus - win-win.

What did the refactor of ScopeTab change?

Nothing, it was replaced with react-aria/focus.

The implementation focuses on this part of the UI. It forces the focus to stay within the popover when it's open. So you can "tab" as many times as you want and it will remain in the same popover.

Screenshot 2023-03-01 at 20 54 30

Before:

File sizes after gzip:

  404.26 kB  build/static/js/main.304b19ba.js
  46.97 kB   build/static/js/52.d0589b8d.chunk.js
  5.35 kB    build/static/js/969.17029516.chunk.js
  3.05 kB    build/static/js/145.69afa4e0.chunk.js
  2.89 kB    build/static/css/main.5456b6c5.css
  389 B      build/static/media/browser-server.38078d2847e4787cc481.js

After:

File sizes after gzip:

  407.38 kB  build/static/js/main.cc5a5564.js
  46.97 kB   build/static/js/52.d0589b8d.chunk.js
  5.35 kB    build/static/js/969.17029516.chunk.js
  3.05 kB    build/static/js/145.69afa4e0.chunk.js
  2.89 kB    build/static/css/main.5456b6c5.css
  389 B      build/static/media/browser-server.38078d2847e4787cc481.js

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/718 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 3/1/2023 **Status:** ✅ Merged **Merged:** 3/5/2023 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `matiss/upgrade-react-modal` --- ### 📝 Commits (3) - [`e44c098`](https://github.com/actualbudget/actual/commit/e44c09871fcf2aaa09ee689c463e054b55fc9914) :arrow_up: upgrade react-modal to v3.16.1 and remove the patch - [`26c59cc`](https://github.com/actualbudget/actual/commit/26c59cc70bb237212b7bd68c0380efb4dd0d30d6) Remove ScopeTab - [`a109576`](https://github.com/actualbudget/actual/commit/a109576937e7c33db5bafe1473e88fa20d99f4c5) Remove console.log ### 📊 Changes **5 files changed** (+13 additions, -48 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/package.json` (+0 -1) 📝 `packages/desktop-client/src/components/accounts/Filters.js` (+3 -23) 📝 `packages/loot-design/package.json` (+1 -1) ➖ `patches/react-modal+3.4.4.patch` (+0 -13) 📝 `yarn.lock` (+9 -10) </details> ### 📄 Description Upgrading `react-modal` and removing the mockey patch. **Is the removal of the monkey-path safe?** I think so.. but I'm not 100% sure. And the git history doesn't help either. So I propose to remove it if we feel reasonably confident that things still work as expected. And if we notice issues after releasing: we can always roll back the change. However: at that point we will actually have some more context on the patch. Thus - win-win. **What did the refactor of `ScopeTab` change?** Nothing, it was replaced with react-aria/focus. The implementation focuses on this part of the UI. It forces the focus to stay within the popover when it's open. So you can "tab" as many times as you want and it will remain in the same popover. <img width="393" alt="Screenshot 2023-03-01 at 20 54 30" src="https://user-images.githubusercontent.com/886567/222262761-ccadb93f-8ccf-4836-b53f-7036e7fa81c2.png"> --- Before: ``` File sizes after gzip: 404.26 kB build/static/js/main.304b19ba.js 46.97 kB build/static/js/52.d0589b8d.chunk.js 5.35 kB build/static/js/969.17029516.chunk.js 3.05 kB build/static/js/145.69afa4e0.chunk.js 2.89 kB build/static/css/main.5456b6c5.css 389 B build/static/media/browser-server.38078d2847e4787cc481.js ``` After: ``` File sizes after gzip: 407.38 kB build/static/js/main.cc5a5564.js 46.97 kB build/static/js/52.d0589b8d.chunk.js 5.35 kB build/static/js/969.17029516.chunk.js 3.05 kB build/static/js/145.69afa4e0.chunk.js 2.89 kB build/static/css/main.5456b6c5.css 389 B build/static/media/browser-server.38078d2847e4787cc481.js ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:39:14 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#3279
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?