github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-10 04:02:38 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #1008] [MERGED] Fix for issue #319 #3463

New Issue
Closed
opened 2026-02-28 20:42:01 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:42:01 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/1008
Author: @TheTrueCaligari
Created: 5/7/2023
Status: ✅ Merged
Merged: 5/9/2023
Merged by: @j-f1

Base: master ← Head: master

📝 Commits (7)

📊 Changes

2 files changed (+38 additions, -4 deletions)

View changed files

📝 packages/desktop-client/src/components/accounts/Account.js (+32 -4)
➕ upcoming-release-notes/1008.md (+6 -0)

📄 Description

I tried to fix the Upcoming/Due transactions not being summed in the Selected Balance.

The problem seems to come from the fact that those transactions are not transactions, hence they don't appear in the sum query.
I think I fixed it with a loop on the different schedules, taking only the right ones (and fixing the sign for transfers with the additional parameter account).

I also tried to do the same thing using another sum query, something like this:

  let scheduleBalance = useSheetValue({
    name: name + '-schedule-sum',
    query: q('schedules')
      .filter({ id: { $oneof: previewIds } })
      .options({ splits: 'all' })
      .calculate({ $sum: '$_amount' }),
  });

but it didn't work :(

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/1008 **Author:** [@TheTrueCaligari](https://github.com/TheTrueCaligari) **Created:** 5/7/2023 **Status:** ✅ Merged **Merged:** 5/9/2023 **Merged by:** [@j-f1](https://github.com/j-f1) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (7) - [`1c95fc2`](https://github.com/actualbudget/actual/commit/1c95fc2da3c110206ca484fa6f94f6fdcb649e84) Add a new number format (space-dot) - [`c925ba2`](https://github.com/actualbudget/actual/commit/c925ba2ae8eb6298489dfc28ce870a55112140b0) Release notes - [`1520adf`](https://github.com/actualbudget/actual/commit/1520adfe88083ad448625a42a47599f463d89eec) Merge branch 'actualbudget:master' into master - [`c932a9a`](https://github.com/actualbudget/actual/commit/c932a9a0edcfed18b2976522151a30d9e66f8cdd) Merge branch 'actualbudget:master' into master - [`32d7fc9`](https://github.com/actualbudget/actual/commit/32d7fc99f7da2afd97bdeaa49fa383b8dd911063) Fix for the issue #319 - [`8e185cf`](https://github.com/actualbudget/actual/commit/8e185cf055bd39e6310ade8fb9ce3add94991ec2) Release note - [`f3bdb74`](https://github.com/actualbudget/actual/commit/f3bdb7498621f014cf784cd4f99e6ac5d4efb522) Adding braces ### 📊 Changes **2 files changed** (+38 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/accounts/Account.js` (+32 -4) ➕ `upcoming-release-notes/1008.md` (+6 -0) </details> ### 📄 Description I tried to fix the Upcoming/Due transactions not being summed in the *Selected Balance*. The problem seems to come from the fact that those transactions are *not* transactions, hence they don't appear in the sum query. I think I fixed it with a loop on the different schedules, taking only the right ones (and fixing the sign for transfers with the additional parameter *account*). I also tried to do the same thing using another sum query, something like this: ```javascript let scheduleBalance = useSheetValue({ name: name + '-schedule-sum', query: q('schedules') .filter({ id: { $oneof: previewIds } }) .options({ splits: 'all' }) .calculate({ $sum: '$_amount' }), }); ``` but it didn't work :( --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:42:01 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#3463
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?