github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-10 04:02:38 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[Bug]: Template "% of previous" + "up to" doesn't work, but passes validation #1008

New Issue
Closed
opened 2026-02-28 19:28:11 -06:00 by GiteaMirror · 4 comments
GiteaMirror commented 2026-02-28 19:28:11 -06:00
Owner
Copy Link

Originally created by @kymckay on GitHub (Mar 28, 2024).

Verified issue does not already exist?

  • I have searched and found no existing issue

Is this related to GoCardless, Simplefin or another bank-sync provider?

  • I have checked my server logs and could not see any errors there
  • I will be attaching my server logs to this issue
  • I will be attaching my client-side (browser) logs to this issue
  • I understand that this issue will be automatically closed if insufficient information is provided

What happened?

#template 15% of previous Salary up to 20000

This template doesn't work as expected, it always adds 0 to the category even though it's below the value of 20000. However, it passes validation just fine. Haven't looked at the code, but perhaps it's interpreting all of "Salary up to 20000" as the category to pull from (which doesn't exist).

Use case: For something like an emergency fund. There's also a possible templates feature gap here where once you hit a limit you want the same percentage to go to Savings instead.

What error did you receive?

No response

Where are you hosting Actual?

Docker

What browsers are you seeing the problem on?

Firefox

Operating System

Linux

Originally created by @kymckay on GitHub (Mar 28, 2024). ### Verified issue does not already exist? - [X] I have searched and found no existing issue ### Is this related to GoCardless, Simplefin or another bank-sync provider? - [ ] I have checked my server logs and could not see any errors there - [ ] I will be attaching my server logs to this issue - [ ] I will be attaching my client-side (browser) logs to this issue - [X] I understand that this issue will be automatically closed if insufficient information is provided ### What happened? ```#template 15% of previous Salary up to 20000``` This template doesn't work as expected, it always adds 0 to the category even though it's below the value of 20000. However, it passes validation just fine. Haven't looked at the code, but perhaps it's interpreting all of "Salary up to 20000" as the category to pull from (which doesn't exist). Use case: For something like an emergency fund. There's also a possible templates feature gap here where once you hit a limit you want the same percentage to go to Savings instead. ### What error did you receive? _No response_ ### Where are you hosting Actual? Docker ### What browsers are you seeing the problem on? Firefox ### Operating System Linux
GiteaMirror added the bug label 2026-02-28 19:28:11 -06:00
GiteaMirror commented 2026-02-28 19:28:11 -06:00
Author
Owner
Copy Link

@youngcw commented on GitHub (Mar 28, 2024):

I think that is because "Salary up to 20000" is getting parsed as a category name. Since category names are allowed to have white space, names always are just the rest of the line.

@youngcw commented on GitHub (Mar 28, 2024): I think that is because "Salary up to 20000" is getting parsed as a category name. Since category names are allowed to have white space, names always are just the rest of the line.
GiteaMirror commented 2026-02-28 19:28:12 -06:00
Author
Owner
Copy Link

@youngcw commented on GitHub (Mar 29, 2024):

I think if you want that functionality to work you need to make the "up to" its own template.

@youngcw commented on GitHub (Mar 29, 2024): I think if you want that functionality to work you need to make the "up to" its own template.
GiteaMirror commented 2026-02-28 19:28:12 -06:00
Author
Owner
Copy Link

@youngcw commented on GitHub (Apr 2, 2024):

Im closing this since its not really a bug.

@youngcw commented on GitHub (Apr 2, 2024): Im closing this since its not really a bug.
GiteaMirror commented 2026-02-28 19:28:13 -06:00
Author
Owner
Copy Link

@kymckay commented on GitHub (Apr 2, 2024):

Fair, but I do think there's a UX issue here. If the category doesn't exist then the template probably shouldn't pass validation.

@kymckay commented on GitHub (Apr 2, 2024): Fair, but I do think there's a UX issue here. If the category doesn't exist then the template probably shouldn't pass validation.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#1008
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?