[PR #2538] [MERGED] Bugfix:Midnight theme button contrast #34551

Closed
opened 2026-04-20 21:42:06 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/2538
Author: @Jenna59
Created: 4/1/2024
Status: Merged
Merged: 4/9/2024
Merged by: @joel-jeremy

Base: masterHead: bug-btncontrast-issue2488


📝 Commits (10+)

  • d81b65f added green700 (g3) to highlight text in PayeeAutocomplete and CategoryAutocomplete
  • 1b4ec15 added upcoming release note doc for Isuee 2488
  • 17c3cd2 Merge updates from master to feature
  • 2d8aeff modified background and text to meet WCAG AA compliance for contrast
  • 982fb96 updated code for autocomplete highlight on menu items
  • c126afd fixed linting errors and renamed release note
  • 0d4f910 updated release note category from 'bug' to 'bugfix'
  • af1409b fixing the light theme
  • 808c04a merging latest changes from upstream
  • 89cf6bb Merge branch 'master' into bug-btncontrast-issue2488

📊 Changes

7 files changed (+39 additions, -7 deletions)

View changed files

📝 packages/desktop-client/src/components/autocomplete/CategoryAutocomplete.tsx (+12 -2)
📝 packages/desktop-client/src/components/autocomplete/PayeeAutocomplete.tsx (+10 -2)
📝 packages/desktop-client/src/style/themes/dark.ts (+1 -0)
📝 packages/desktop-client/src/style/themes/development.ts (+1 -0)
📝 packages/desktop-client/src/style/themes/light.ts (+3 -0)
📝 packages/desktop-client/src/style/themes/midnight.ts (+6 -3)
upcoming-release-notes/2538.md (+6 -0)

📄 Description

Closes #2488


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/2538 **Author:** [@Jenna59](https://github.com/Jenna59) **Created:** 4/1/2024 **Status:** ✅ Merged **Merged:** 4/9/2024 **Merged by:** [@joel-jeremy](https://github.com/joel-jeremy) **Base:** `master` ← **Head:** `bug-btncontrast-issue2488` --- ### 📝 Commits (10+) - [`d81b65f`](https://github.com/actualbudget/actual/commit/d81b65fcccc58083acd290833f7ccc65259ff3a0) added green700 (g3) to highlight text in PayeeAutocomplete and CategoryAutocomplete - [`1b4ec15`](https://github.com/actualbudget/actual/commit/1b4ec1546cefa7c8c6446e0237ba414a30b086ce) added upcoming release note doc for Isuee 2488 - [`17c3cd2`](https://github.com/actualbudget/actual/commit/17c3cd2910585cb29f0ebeb9d57eed9a44f32ab5) Merge updates from master to feature - [`2d8aeff`](https://github.com/actualbudget/actual/commit/2d8aefff01f061d742476f97389e0cc987111c07) modified background and text to meet WCAG AA compliance for contrast - [`982fb96`](https://github.com/actualbudget/actual/commit/982fb963a91914c0efb3f4335f314e0922a65f40) updated code for autocomplete highlight on menu items - [`c126afd`](https://github.com/actualbudget/actual/commit/c126afd5056ed95e4e4b056d34ceeb1f76f8e588) fixed linting errors and renamed release note - [`0d4f910`](https://github.com/actualbudget/actual/commit/0d4f910af897bb0bb902ad1eddacd5a44d69e081) updated release note category from 'bug' to 'bugfix' - [`af1409b`](https://github.com/actualbudget/actual/commit/af1409bfbc6049398c07ba9558ecb90fcd963c11) fixing the light theme - [`808c04a`](https://github.com/actualbudget/actual/commit/808c04abe238626644a5cb9b8b1c60d061ad4402) merging latest changes from upstream - [`89cf6bb`](https://github.com/actualbudget/actual/commit/89cf6bbf8acf6035a138ae54bebfae4f41337f17) Merge branch 'master' into bug-btncontrast-issue2488 ### 📊 Changes **7 files changed** (+39 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/autocomplete/CategoryAutocomplete.tsx` (+12 -2) 📝 `packages/desktop-client/src/components/autocomplete/PayeeAutocomplete.tsx` (+10 -2) 📝 `packages/desktop-client/src/style/themes/dark.ts` (+1 -0) 📝 `packages/desktop-client/src/style/themes/development.ts` (+1 -0) 📝 `packages/desktop-client/src/style/themes/light.ts` (+3 -0) 📝 `packages/desktop-client/src/style/themes/midnight.ts` (+6 -3) ➕ `upcoming-release-notes/2538.md` (+6 -0) </details> ### 📄 Description Closes #2488 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 21:42:06 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#34551