github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-11 01:18:59 -05:00
Code Issues 1.6k Packages Projects Releases 57 Wiki Activity

[PR #1258] [MERGED] Reorganize Accounts Folder #33824

New Issue
Closed
opened 2026-04-20 21:06:06 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-20 21:06:06 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/1258
Author: @carkom
Created: 7/2/2023
Status: ✅ Merged
Merged: 7/4/2023
Merged by: @j-f1

Base: master ← Head: accounts

📝 Commits (3)

📊 Changes

18 files changed (+968 additions, -940 deletions)

View changed files

📝 packages/desktop-client/src/components/accounts/Account.js (+8 -934)
➕ packages/desktop-client/src/components/accounts/Balance.js (+156 -0)
➕ packages/desktop-client/src/components/accounts/Header.js (+478 -0)
📝 packages/desktop-client/src/components/accounts/MobileAccountDetails.js (+1 -2)
➕ packages/desktop-client/src/components/accounts/Reconcile.js (+128 -0)
📝 packages/desktop-client/src/components/common.tsx (+2 -0)
➕ packages/desktop-client/src/components/common/MenuButton.tsx (+17 -0)
➕ packages/desktop-client/src/components/common/MenuTooltip.tsx (+16 -0)
📝 packages/desktop-client/src/components/filters/SavedFilters.js (+1 -2)
📝 packages/desktop-client/src/components/modals/EditRule.js (+1 -1)
📝 packages/desktop-client/src/components/schedules/EditSchedule.js (+1 -1)
📝 packages/desktop-client/src/components/transactions/MobileTransaction.js (+0 -0)
➕ packages/desktop-client/src/components/transactions/SelectedTransactions.js (+153 -0)
📝 packages/desktop-client/src/components/transactions/SimpleTransactionsTable.js (+0 -0)
📝 packages/desktop-client/src/components/transactions/TransactionList.js (+0 -0)
📝 packages/desktop-client/src/components/transactions/TransactionsTable.js (+0 -0)
📝 packages/desktop-client/src/components/transactions/TransactionsTable.test.js (+0 -0)
➕ upcoming-release-notes/1258.md (+6 -0)

📄 Description

There's no new code here, just a reorg. Had to change some import calls in some files to make it all work properly.

Having just done a lot of work in the accounts directory I figured it could do with some organization. I've broken out all the Header functions into a different file in order to cut down on the size of the account.js file.

I also moved the transactions files into a new directory since they are used by other pages. Also makes them easier to find with this structure.

Let me know what you think!

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/1258 **Author:** [@carkom](https://github.com/carkom) **Created:** 7/2/2023 **Status:** ✅ Merged **Merged:** 7/4/2023 **Merged by:** [@j-f1](https://github.com/j-f1) **Base:** `master` ← **Head:** `accounts` --- ### 📝 Commits (3) - [`91536f9`](https://github.com/actualbudget/actual/commit/91536f9abafc95865e14da7846bda356137c2e33) resubmitting changes - [`c83cac3`](https://github.com/actualbudget/actual/commit/c83cac3c87a65deac0a4ca52780b97c3d4c32a23) Merge branch 'master' into accounts - [`660949c`](https://github.com/actualbudget/actual/commit/660949cb6a138f87fee708619af7661c75d30bdd) fixes ### 📊 Changes **18 files changed** (+968 additions, -940 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/accounts/Account.js` (+8 -934) ➕ `packages/desktop-client/src/components/accounts/Balance.js` (+156 -0) ➕ `packages/desktop-client/src/components/accounts/Header.js` (+478 -0) 📝 `packages/desktop-client/src/components/accounts/MobileAccountDetails.js` (+1 -2) ➕ `packages/desktop-client/src/components/accounts/Reconcile.js` (+128 -0) 📝 `packages/desktop-client/src/components/common.tsx` (+2 -0) ➕ `packages/desktop-client/src/components/common/MenuButton.tsx` (+17 -0) ➕ `packages/desktop-client/src/components/common/MenuTooltip.tsx` (+16 -0) 📝 `packages/desktop-client/src/components/filters/SavedFilters.js` (+1 -2) 📝 `packages/desktop-client/src/components/modals/EditRule.js` (+1 -1) 📝 `packages/desktop-client/src/components/schedules/EditSchedule.js` (+1 -1) 📝 `packages/desktop-client/src/components/transactions/MobileTransaction.js` (+0 -0) ➕ `packages/desktop-client/src/components/transactions/SelectedTransactions.js` (+153 -0) 📝 `packages/desktop-client/src/components/transactions/SimpleTransactionsTable.js` (+0 -0) 📝 `packages/desktop-client/src/components/transactions/TransactionList.js` (+0 -0) 📝 `packages/desktop-client/src/components/transactions/TransactionsTable.js` (+0 -0) 📝 `packages/desktop-client/src/components/transactions/TransactionsTable.test.js` (+0 -0) ➕ `upcoming-release-notes/1258.md` (+6 -0) </details> ### 📄 Description There's no new code here, just a reorg. Had to change some import calls in some files to make it all work properly. Having just done a lot of work in the accounts directory I figured it could do with some organization. I've broken out all the Header functions into a different file in order to cut down on the size of the account.js file. I also moved the transactions files into a new directory since they are used by other pages. Also makes them easier to find with this structure. Let me know what you think! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 21:06:06 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#33824
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?