github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-10 12:12:39 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #836] [MERGED] 🐛 (autocomplete) delay when switching from Select to CreatableSelect #3354

New Issue
Closed
opened 2026-02-28 20:40:21 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:40:21 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/836
Author: @MatissJanis
Created: 3/31/2023
Status: ✅ Merged
Merged: 3/31/2023
Merged by: @MatissJanis

Base: master ← Head: matiss/autocomplete-delay

📝 Commits (3)

  • acf80e7 🐛 (autocomplete) delay when switching from Select to CreatableSelect
  • 0781909 Release notes
  • e781435 Feedback: use isValidNewOption

📊 Changes

2 files changed (+7 additions, -3 deletions)

View changed files

📝 packages/desktop-client/src/components/autocomplete/NewPayeeAutocomplete.js (+1 -3)
➕ upcoming-release-notes/836.md (+6 -0)

📄 Description

When you open the payee autocomplete and click on "make transfer" button in the footer: there is a noticable delay between the renders.

This is because the previous CreatableSelect component is unmounted and a new Select component gets mounted. The only difference between the two: ability to create new payees.

If we remove this logic and simply always keep the component in the creatable state - there are no long re-mounts and thus the flow is not so disruptive. But the downside is: you can create payees whilst in the "transfer" mode.

Not exactly the best solution.. but IMO it's better this way than with the massive delay.

https://github.com/actualbudget/actual/issues/773

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/836 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 3/31/2023 **Status:** ✅ Merged **Merged:** 3/31/2023 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `matiss/autocomplete-delay` --- ### 📝 Commits (3) - [`acf80e7`](https://github.com/actualbudget/actual/commit/acf80e7b5e2dcc3bb5dae265f7d1280384ead9cc) :bug: (autocomplete) delay when switching from Select to CreatableSelect - [`0781909`](https://github.com/actualbudget/actual/commit/078190915de44cb989cf8346ce0c084925e8029a) Release notes - [`e781435`](https://github.com/actualbudget/actual/commit/e781435a5d2f4a60212be3b3e53d9f41f5029225) Feedback: use isValidNewOption ### 📊 Changes **2 files changed** (+7 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/autocomplete/NewPayeeAutocomplete.js` (+1 -3) ➕ `upcoming-release-notes/836.md` (+6 -0) </details> ### 📄 Description When you open the payee autocomplete and click on "make transfer" button in the footer: there is a noticable delay between the renders. This is because the previous `CreatableSelect` component is unmounted and a new `Select` component gets mounted. The only difference between the two: ability to create new payees. If we remove this logic and simply always keep the component in the `creatable` state - there are no long re-mounts and thus the flow is not so disruptive. But the downside is: you can create payees whilst in the "transfer" mode. Not exactly the best solution.. but IMO it's better this way than with the massive delay. https://github.com/actualbudget/actual/issues/773 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:40:21 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#3354
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?