github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 07:01:45 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #2646] [CLOSED] Fix OFX import with non-unique FITID #30355

New Issue
Closed
opened 2026-04-18 06:44:11 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-18 06:44:11 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/2646
Author: @Wizmaster
Created: 4/20/2024
Status: ❌ Closed

Base: master ← Head: bugfix/ofx-import-reused-fitid

📝 Commits (1)

  • 5eb4afa Fix OFX import with non-unique FITID

📊 Changes

3 files changed (+24 additions, -6 deletions)

View changed files

📝 packages/api/methods.test.ts (+1 -1)
📝 packages/loot-core/src/server/accounts/sync.ts (+17 -5)
➕ upcoming-release-notes/2646.md (+6 -0)

📄 Description

Fix #608

When importing, only merge transaction found with same imported_id if the imported_payee and amount also match, and if a single transaction was found. Else let the fuzzy matching try to find a transaction match.

In the comment https://github.com/actualbudget/actual/issues/608#issuecomment-2067322290 I thought using the date to match the transaction but decided against it, the user could change the date to their liking and matching on it would becomes unreliable.

Testing with the OFX files provided in #608 was conclusive. Only 3 transactions were mistakenly merged:

  • 1 due to issue #2420, the dates where close enough and the amounts the same
  • 2 due to fitid, amounts and payee info being the same (the issue arose because the payee used were "Generic Transaction #xx" with xx being the fitid, something I believe unlikely with real data)

Testing with my own data was also ok.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/2646 **Author:** [@Wizmaster](https://github.com/Wizmaster) **Created:** 4/20/2024 **Status:** ❌ Closed **Base:** `master` ← **Head:** `bugfix/ofx-import-reused-fitid` --- ### 📝 Commits (1) - [`5eb4afa`](https://github.com/actualbudget/actual/commit/5eb4afa07640ce203f102ecfdc892fc4a8342670) Fix OFX import with non-unique FITID ### 📊 Changes **3 files changed** (+24 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `packages/api/methods.test.ts` (+1 -1) 📝 `packages/loot-core/src/server/accounts/sync.ts` (+17 -5) ➕ `upcoming-release-notes/2646.md` (+6 -0) </details> ### 📄 Description Fix #608 When importing, only merge transaction found with same imported_id if the imported_payee and amount also match, and if a single transaction was found. Else let the fuzzy matching try to find a transaction match. In the comment https://github.com/actualbudget/actual/issues/608#issuecomment-2067322290 I thought using the date to match the transaction but decided against it, the user could change the date to their liking and matching on it would becomes unreliable. Testing with the OFX files provided in #608 was conclusive. Only 3 transactions were mistakenly merged: - 1 due to issue #2420, the dates where close enough and the amounts the same - 2 due to fitid, amounts and payee info being the same (the issue arose because the payee used were "Generic Transaction #xx" with xx being the fitid, something I believe unlikely with real data) Testing with my own data was also ok. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-18 06:44:11 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#30355
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?