github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 07:01:45 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #2638] [MERGED] Fix menuItemTextHeader contrast in dark mode #30350

New Issue
Closed
opened 2026-04-18 06:43:59 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-18 06:43:59 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/2638
Author: @matt-fidd
Created: 4/19/2024
Status: ✅ Merged
Merged: 4/27/2024
Merged by: @youngcw

Base: master ← Head: 2395

📝 Commits (6)

  • f841f14 Fix menuItemTextHeader contrast in dark mode
  • 9a6d335 release note
  • 1d40d3b darken menu background and change accent colour to purple in dark theme
  • 9ce7cc6 change menu keybind accept colour to purple in midnight theme
  • 2bf8f55 update release note
  • 61170f4 fix menuBorder colour

📊 Changes

3 files changed (+12 additions, -6 deletions)

View changed files

📝 packages/desktop-client/src/style/themes/dark.ts (+5 -5)
📝 packages/desktop-client/src/style/themes/midnight.ts (+1 -1)
➕ upcoming-release-notes/2638.md (+6 -0)

📄 Description

Fixes #2395
Fixes #2644

https://webaim.org/resources/contrastchecker/?fcolor=F2EBFE&bcolor=486581

image

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/2638 **Author:** [@matt-fidd](https://github.com/matt-fidd) **Created:** 4/19/2024 **Status:** ✅ Merged **Merged:** 4/27/2024 **Merged by:** [@youngcw](https://github.com/youngcw) **Base:** `master` ← **Head:** `2395` --- ### 📝 Commits (6) - [`f841f14`](https://github.com/actualbudget/actual/commit/f841f149035b2323db3fd25e2b7ce18f6eafbf85) Fix menuItemTextHeader contrast in dark mode - [`9a6d335`](https://github.com/actualbudget/actual/commit/9a6d3357cd62d34b5db10f6a57ba85e96e9541dd) release note - [`1d40d3b`](https://github.com/actualbudget/actual/commit/1d40d3b7092b88e76e0ed349cfea8ebeb8860486) darken menu background and change accent colour to purple in dark theme - [`9ce7cc6`](https://github.com/actualbudget/actual/commit/9ce7cc675005502b3f573063cb0a695face8832c) change menu keybind accept colour to purple in midnight theme - [`2bf8f55`](https://github.com/actualbudget/actual/commit/2bf8f55e0803c0bed10e095c31604f0f52276727) update release note - [`61170f4`](https://github.com/actualbudget/actual/commit/61170f48f3de99f58dd1cf0b72d791460e8bf47a) fix menuBorder colour ### 📊 Changes **3 files changed** (+12 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/style/themes/dark.ts` (+5 -5) 📝 `packages/desktop-client/src/style/themes/midnight.ts` (+1 -1) ➕ `upcoming-release-notes/2638.md` (+6 -0) </details> ### 📄 Description Fixes #2395 Fixes #2644 https://webaim.org/resources/contrastchecker/?fcolor=F2EBFE&bcolor=486581 ![image](https://github.com/actualbudget/actual/assets/81489167/7813bff0-3413-482e-8456-4479c6e0dd50) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-18 06:43:59 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#30350
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?